Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:590
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <5.1.0.14.2.20030402092156.0310bb68@127.0.0.1>
Date: Wed, 02 Apr 2003 09:23:44 +0300
To: Sascha Schumann <sascha@schumann.cx>
Cc: Sebastian Bergmann <sebastian@php.net>, internals@lists.php.net
In-Reply-To: <Pine.LNX.4.53.0304020815060.8659@eco.foo>
References: <5.1.0.14.2.20030402091017.032db718@127.0.0.1>
 <5.1.0.14.2.20030402091017.032db718@127.0.0.1>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
Subject: Re: [PHP-DEV] Doc Comments cause parser errors
From: andi@zend.com (Andi Gutmans)

At 08:16 AM 4/2/2003 +0200, Sascha Schumann wrote:
>On Wed, 2 Apr 2003, Andi Gutmans wrote:
>
> > AFAIK, doc comments are for classes and functions only. I think this is
> > what's important because interfaces are functions not variables.
>
>     Hm, so my PHP 4-stylish code would cause a parse error, if it
>     contained a valid character like a "*" after the initiation
>     sequence "/*"?

Oh, I didn't think of that. You are completely right. This is definitely a 
problem. Andrei's patch returns a token for /** */ on the parser level so 
only places which are allowed to have this work.
This sounds like a serious flaw because any place which has such comments 
will fail. I guess we'll need to revert his patch and try to think of a 
completely different way of doing it (unless someone has a good idea of how 
to solve this problem).

Andi