Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58982
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <op.wa909ikgidpuyk@damnation.mshome.net>
References: <3ADF645454450443973DDB04FC00A0E525885F35@TK5EX14MBXC296.redmond.corp.microsoft.com>
	<op.wa8ficfzidpuyk@damnation.mshome.net>
	<3ADF645454450443973DDB04FC00A0E525887C88@TK5EX14MBXC296.redmond.corp.microsoft.com>
	<op.wa909ikgidpuyk@damnation.mshome.net>
Date: Sat, 17 Mar 2012 10:08:14 +0100
Message-ID: <CAEZPtU4oMA9Vqzv59Nn39RtcGD7Hyg9u-U9S52WN4Ro_9Gjkew@mail.gmail.com>
To: Gustavo Lopes <glopes@nebm.ist.utl.pt>
Cc: Eric Stenson <ericsten@microsoft.com>, 
	"internals@lists.php.net" <internals@lists.php.net>, Dmitry Stogov <dmitry@zend.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Q: ZEND_HANDLE_STREAM and wincache extension on PHP 5.4
From: pierre.php@gmail.com (Pierre Joye)

hi,

On Fri, Mar 16, 2012 at 7:49 PM, Gustavo Lopes <glopes@nebm.ist.utl.pt> wrote:

> It's best you send him an e-mail to dmitry@zend.com

No, it is best to send a mail to internals and cc him.

>> I was talking with Pierre yesterday, and there was some question about
>> whether there was some distinction between streams that were created as a
>> result of zend_compile_file versus just those files that were called by
>> calling
>> zend_stream_open_function.
>
>
> What would this distinction be and what would be the implication?

See the wincache code please. This comment was only about the wincache
implementation. Also it is only about knowing whether we are in RINIT
or at runtime, as in, compile file being called from the SAPI or from
require/include&co.


> I think the reason phar causes no problem is because CGI will not be opening
> phar:// files as a first script, which is all php_cgi!main() deals with. So
> phar's zend_stream_function will in this case end up falling back on the
> default implementation and cause no problem.

Yes, see my reply earlier.

> In any case, it's true that default implementation of
> zend_stream_open_function (php_stream_open_for_zend_ex) does store a
> php_stream* in handle. However, this clearly isn't the general case (even it
> were, breaking the abstraction would already be dubious). This is definitely
> a bug.

It is not necessary a bug but a breakage in the ABI, and not
documented. I discussed it with Dmitry and it was not seen as a bug
but as an optimization. The problem in wincache is somehow special due
the file caching mechanism, which mix up both SAPI file open and
runtime file open, which ends in the current issue.

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org