Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58973
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.22 cause and error)
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: internals@lists.php.net, ericsten@microsoft.com
References: <3ADF645454450443973DDB04FC00A0E525885F35@TK5EX14MBXC296.redmond.corp.microsoft.com>
Date: Thu, 15 Mar 2012 23:02:26 +0100
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Organization: =?utf-8?Q?N=C3=BAcleo_de_Eng=2E_Biom=C3=A9di?=
 =?utf-8?Q?ca_do_I=2ES=2ET=2E?=
Message-ID: <op.wa8ficfzidpuyk@damnation.mshome.net>
In-Reply-To: <3ADF645454450443973DDB04FC00A0E525885F35@TK5EX14MBXC296.redmond.corp.microsoft.com>
User-Agent: Opera Mail/11.61 (Win32)
Subject: Re: [PHP-DEV] Q: ZEND_HANDLE_STREAM and wincache extension on PHP 5.4
From: glopes@nebm.ist.utl.pt ("Gustavo Lopes")

On Thu, 15 Mar 2012 19:56:11 +0100, Eric Stenson <ericsten@microsoft.com>  
wrote:

>
> The problem I'm running into is the php_cgi!main() on PHP5.4 has changed
> behavior.  The php_cgi!main() function is seeing us return a  
> ZEND_HANDLE_STREAM,
> and it's assuming that the zend_file_handle.handle.stream.handle (void *)
> is a (php_stream*), when in fact it's php_wincache's (fcache_handle *).
> It then attempts to access the php_stream.ops (a v-table-ish struct),  
> which is not in the fcache_handle, and it jumps off into an invalid  
> address and
> promptly AV's.
>
> [...]

I think you should contact Dmitry, as he was the one that committed  
r301058. That code looks very strange. It seems to want to break the  
abstraction of zend_stream and assume that handle stores a php_stream (to  
use e.g. zend_stream_getc instead of php_stream_getc).

But I don't think the assumption done to break the abstraction is correct.  
For instance, see

http://lxr.php.net/opengrok/xref/PHP_TRUNK/ext/phar/phar.c#3364

which has:

file_handle->handle.stream.handle = phar;

and *phar is of type phar_archive_data, which is not a php_stream (or an  
augmentation thereof).

-- 
Gustavo Lopes