Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58955
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender)
MIME-Version: 1.0
Sender: tjerk.meesters@gmail.com
In-Reply-To: <4F61BE09.3040705@rotorised.com>
References: <4F60F4B1.5010407@lerdorf.com>
	<4F611045.8040404@rotorised.com>
	<4F618F30.7060209@sugarcrm.com>
	<4F61BE09.3040705@rotorised.com>
Date: Thu, 15 Mar 2012 19:06:34 +0800
Message-ID: <CAHMUw2H_a1mS6z8AmCLPToTTtdsT4Ob3ewyAz+j-_MZmwqQLbA@mail.gmail.com>
To: Ryan McCue <lists@rotorised.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Let parse_str() parse more than max_input_vars args
From: datibbaw@php.net (Tjerk Anne Meesters)

On Thu, Mar 15, 2012 at 6:01 PM, Ryan McCue <lists@rotorised.com> wrote:
>>> That's probably going to confuse people if it doesn't change the HTTP
>>> request parsing limit too, IMHO. And I'm not sure that's something we
>>> necessarily want.
>>
>>
>> Err, how you can change it after HTTP request has already been parsed?
>>
>
> I'm not arguing that it should, I'm saying that in the INI it refers to the
> HTTP arguments, while in the code (via ini_set) it would not affect this. I
> think that could be confusing for users who don't realise the script is only
> loaded after parsing the request.
>

That's something I hadn't even considered, that by turning the setting
into INI_ALL the expected behaviour is in fact broken when using
ini_set(); it doesn't do the same thing any more.

>
> I think that is definitely a documentation issue, but the extra argument is
> the way to go in terms of being the least confusing option.
>

After looking back at my previous comment I realized that, between the
two suboptimal fixes, adding the extra argument is actually the better
one; I see now that it makes a clearer statement that changing this
ini setting can only be done inside the more privileged code of
parse_str().

I had reasoned before that by having to use ini_set() the developer
would be more aware of the linkage between parse_str and
max_input_vars, but a good example in the parse_str() documentation
should be able to address that and the "strange" error message one
would see if the limits are exceeded :)