Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58954
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain rotorised.com from 203.88.115.241 cause and error)
Message-ID: <4F61BE09.3040705@rotorised.com>
Date: Thu, 15 Mar 2012 20:01:45 +1000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
MIME-Version: 1.0
To: "internals@lists.php.net" <internals@lists.php.net>
References: <4F60F4B1.5010407@lerdorf.com> <4F611045.8040404@rotorised.com> <4F618F30.7060209@sugarcrm.com>
In-Reply-To: <4F618F30.7060209@sugarcrm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Let parse_str() parse more than max_input_vars args
From: lists@rotorised.com (Ryan McCue)

Stas Malyshev wrote:
> Hi!
>
>> That's probably going to confuse people if it doesn't change the HTTP
>> request parsing limit too, IMHO. And I'm not sure that's something we
>> necessarily want.
>
> Err, how you can change it after HTTP request has already been parsed?
>

I'm not arguing that it should, I'm saying that in the INI it refers to 
the HTTP arguments, while in the code (via ini_set) it would not affect 
this. I think that could be confusing for users who don't realise the 
script is only loaded after parsing the request.

Rasmus Lerdorf wrote:
> I think that is a documentation issue. We already have plenty of
> confusion here because it isn't documented that parse_str() is affected
> by the max_input_vars setting.

I think that is definitely a documentation issue, but the extra argument 
is the way to go in terms of being the least confusing option.

-- 
Ryan McCue
<http://ryanmccue.info/>