Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58948
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.42 as permitted sender)
MIME-Version: 1.0
Sender: tjerk.meesters@gmail.com
In-Reply-To: <4F612BF6.3070301@lerdorf.com>
References: <4F60F4B1.5010407@lerdorf.com>
	<CAJy+15xdm9SxZBaPqnRb4ushqEuF35Xn-k21jj=FE_i1Ej6w9Q@mail.gmail.com>
	<4F612BF6.3070301@lerdorf.com>
Date: Thu, 15 Mar 2012 10:34:15 +0800
Message-ID: <CAHMUw2FHyMLHCKgtNLrJfRzSBUEiFQbTER-G-_q_4vph8Xy7Xg@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: Ilia Alshanetsky <ilia@prohost.org>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Let parse_str() parse more than max_input_vars args
From: datibbaw@php.net (Tjerk Anne Meesters)

On Thu, Mar 15, 2012 at 7:38 AM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:
>
> Yes, it would need a zend_alter_ini_entry_ex() call there. The patch
> wasn't complete, just a quick hack. But it would still have an
> out-of-context error message when you exceed it. At least with a
> userspace ini_set() the error would make sense.
>

As mentioned on IRC, a function signature of "array
parse_urlencoded(string $s)" would be useful too; the separated logic
would allow for avoiding max_input_vars altogether and not having to
worry about parameter name mangling (variable name rules). The nasty
part is that much of the treat_data code would have to be duplicated
(I think).

Besides that, applying the hash randomisation patch to only userland
arrays would make the max_input_vars less critical and at the same
time avoid breaking opcode caches and other low-level dependencies.