Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58947
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.161.170 cause and error)
Message-ID: <4F612BF6.3070301@lerdorf.com>
Date: Wed, 14 Mar 2012 16:38:30 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
MIME-Version: 1.0
To: Ilia Alshanetsky <ilia@prohost.org>
CC: PHP internals <internals@lists.php.net>
References: <4F60F4B1.5010407@lerdorf.com> <CAJy+15xdm9SxZBaPqnRb4ushqEuF35Xn-k21jj=FE_i1Ej6w9Q@mail.gmail.com>
In-Reply-To: <CAJy+15xdm9SxZBaPqnRb4ushqEuF35Xn-k21jj=FE_i1Ej6w9Q@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Let parse_str() parse more than max_input_vars args
From: rasmus@lerdorf.com (Rasmus Lerdorf)

On 03/14/2012 04:27 PM, Ilia Alshanetsky wrote:
> Sounds like a least dangerous way of solving the problem to me. The
> only issue I can see with this fix is what would happen is if after
> the "PG(max_input_vars) = max_vars;	"
> call the request got interrupted in persistent environment such as
> Apache (mod_php). Wouldn't that means that for subsequent requests the
> value would not be equal to the one set by the user?

Yes, it would need a zend_alter_ini_entry_ex() call there. The patch
wasn't complete, just a quick hack. But it would still have an
out-of-context error message when you exceed it. At least with a
userspace ini_set() the error would make sense.

-Rasmus