Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58945
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain prohost.org designates 209.85.215.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4F60F4B1.5010407@lerdorf.com>
References: <4F60F4B1.5010407@lerdorf.com>
Date: Wed, 14 Mar 2012 19:27:03 -0400
Message-ID: <CAJy+15xdm9SxZBaPqnRb4ushqEuF35Xn-k21jj=FE_i1Ej6w9Q@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Let parse_str() parse more than max_input_vars args
From: ilia@prohost.org (Ilia Alshanetsky)

Sounds like a least dangerous way of solving the problem to me. The
only issue I can see with this fix is what would happen is if after
the "PG(max_input_vars) = max_vars;	"
call the request got interrupted in persistent environment such as
Apache (mod_php). Wouldn't that means that for subsequent requests the
value would not be equal to the one set by the user?

On Wed, Mar 14, 2012 at 3:42 PM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:
> It is somewhat unintuitive that parse_str() is subject to the
> max_input_vars limitation and there are sites that use parse_str() to
> parse things that aren't directly coming from user query args.
> There arr two ways to solve this. We could add an optional max_vars arg
> something along these lines:
>
> https://gist.github.com/2038870
>
> The other way to solve this would be to make max_input_vars PHP_INI_ALL
> and then just let people ini_set() their way around the limit.
>
> The one drawback with the optional arg approach is that since
> parse_str() is a thin layer on top of the query string parser, the error
> if you exceed the passed max_vars talks about the ini setting which in
> this case wouldn't really be correct and fixing that would be complicated.
>
> -Rasmus
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>