Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58907
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.203 as permitted sender)
Message-ID: <4F5E85E1.5050202@sugarcrm.com>
Date: Mon, 12 Mar 2012 16:25:21 -0700
Organization: SugarCRM
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0.1) Gecko/20120208 Thunderbird/10.0.1
MIME-Version: 1.0
To: =?UTF-8?B?w4FuZ2VsIEdvbnrDoWxleg==?= <keisial@gmail.com>
CC: Rasmus Lerdorf <rasmus@lerdorf.com>, 
 PHP internals <internals@lists.php.net>
References: <4F5D9C77.3030000@lerdorf.com> <4F5DA152.10109@sugarcrm.com> <4F5DA894.8060606@lerdorf.com> <4F5DAB49.3030808@sugarcrm.com> <4F5DAFCE.8020600@lerdorf.com> <4F5E5148.4030106@sugarcrm.com> <4F5E5219.7080501@lerdorf.com> <4F5E53C3.8060502@sugarcrm.com> <4F5E6A0C.90507@gmail.com> <4F5E6AF4.9090603@sugarcrm.com> <4F5E7F66.6000304@gmail.com>
In-Reply-To: <4F5E7F66.6000304@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] default charset confusion
From: smalyshev@sugarcrm.com (Stas Malyshev)

Hi!

> Still, that API is likely wrong: a library function written by someone
> completely unrelated to the main application shouldn't be echoing
> anything through the output. And if it's not generating the html, the
> htmlspecialchars is better done from the return at the calling
> application (probably after converting the internal charset).

Again, you making a huge amount of assumptions about how ALL the 
applications must work, which means you are wrong in 99.(9)% of cases, 
because there's infinitely many applications which don't work exactly 
like yours does, and we have no idea how they work.

The main point is that having global state (and yet worse, changeable 
global state) significantly influence how basic functions are working is 
dangerous. It's like keeping everything in globals and instead of 
passing parameters between functions just change some globals and expect 
functions to pick it up.

> Such interfaces may be well served by switching the setting many times.

That's exactly what I am trying to avoid, and you are just illustrating 
why this proposal is dangerous - because that's exactly what is going to 
happen in the code, instead of passing proper arguments to 
htmlspecialchars people will start changing INI settings left and right, 
and then nobody would know what htmlspecialchars() call actually does 
without tracking all the INI changes along the way.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227