Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58874
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAJWj5+F0e8SUgH_V-aXvdwJkvxMnxiL7GHKr8iXzD5bwii6Chw@mail.gmail.com>
References: <CAAyV7nHOwCoci6W7-cvFEJi27Wz7qA-_0a6_qHVyzwkC6rjWQQ@mail.gmail.com>
 <CAMyk_AY-vYp_VbctGomyKN0fra0QU3E=rRmacazrRDWeZNgHPg@mail.gmail.com>
 <CAAyV7nHZohu1rkuLFdzAdD_JX3jgVJcfkxbdc6ZnuUCSvEGnJA@mail.gmail.com>
 <CAMyk_AZuhgmsb8ONpW3kYV7FgwBr4csGs+xoDrEt=c=c-PtvEA@mail.gmail.com>
 <CAJWj5+E8KSXzugb6xz+xm26WMPNxdoSaS14cZ8vpxYF2GCT7qw@mail.gmail.com>
 <CAMyk_AaOKOD1=Fxj=4iY56P7gCxb410hg_x9dER8qiTjnpvUTA@mail.gmail.com>
 <C379A30D-3B12-4C2B-B3A0-0B4D1B92BC44@gmail.com> <CAAyV7nF9GDAN4f92+XkKjLAGnZ4KukFOt0uMf2=hyA38M0YS2A@mail.gmail.com>
 <CAL0xaBGL9ReS=zEo74rARrRRW7Fhjdg27Ni5ghzs8vpHoaP1eA@mail.gmail.com>
 <CAAyV7nH7g3x7PcQr49GPLQH0jVdbqpYornBjPcnrKd3VSEayzQ@mail.gmail.com>
 <CAL0xaBEdgd4SNhuFya2Jjuhkfj2GSc-qezHZQ5fd832tJ_UMaw@mail.gmail.com>
 <CAAyV7nExGxcy4aAd-zd+SdDue_=5V9vF57z6KBzkK5049KyQTg@mail.gmail.com>
 <CAMyk_AYhWwzKNSWdg1eS0MTCrwnYYq+n+kvBDo6qyaOLrmkiJQ@mail.gmail.com> <CAJWj5+F0e8SUgH_V-aXvdwJkvxMnxiL7GHKr8iXzD5bwii6Chw@mail.gmail.com>
Date: Mon, 12 Mar 2012 14:46:44 +0100
Message-ID: <CAMyk_AaTUn-uSzOxUTdnuPkWdSJ4dRJ=r=Onr9jffa_RjSjSDQ@mail.gmail.com>
To: Simon Schick <simonsimcity@googlemail.com>
Cc: Anthony Ferrara <ircmaxell@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=0016368e1d5b5c8a7904bb0bfa23
Subject: Re: [PHP-DEV] [POC - Patch] Scalar Type Hinting - A-La zend_parse_parameters
From: linepogl@gmail.com (Lazare Inepologlou)

--0016368e1d5b5c8a7904bb0bfa23
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Simon,

First of all, none of your examples cover the case I mentioned, and so, my
concerns are still valid.

Secondly, you make some wrong assumptions about how this specific POC
works. For example, you write:

> function foo(int $d =3D 20) { var_dump($d); }
> foo(null); // This should then also simply fail.

Unless I am wrong, the patch will convert null to 0.


Lazare INEPOLOGLOU
Ing=C3=A9nieur Logiciel


2012/3/12 Simon Schick <simonsimcity@googlemail.com>

> 2012/3/12 Lazare Inepologlou <linepogl@gmail.com>
> >
> > function set_check_box_state( bool state =3D false ) { ... }
> > set_check_box_state( null );  // null will be converted to false here..=
.
> >
> > Therefore, this cannot work, unless the default value becomes null, whi=
ch
> > is against the requirements. What I suggest is something like this:
> >
> > function set_check_box_state( bool? state =3D false ) { ... }
> > set_check_box_state( null );  // works fine
> >
> > In my opinion this is much clearer, as it separates the notions of the
> > type
> > and that of the default value.
> >
> >
> > Lazare INEPOLOGLOU
> > Ing=C3=A9nieur Logiciel
>
> Hi Lazare,
>
> I'd like to keep the accptance of null as it is for classes and arrays.
> Here's an example I wrote earlier:
>
> function foo(array $d =3D array()) { var_dump($d); }
> foo(null); // This fails with the message: Argument 1 passed to foo()
> must be an array, null given
>
> As this code fails I'd not expect to change this behavior for the new
> feature we're discussing here.
>
> function foo(int $d =3D 20) { var_dump($d); }
> foo(null); // This should then also simply fail. Don't care about
> what's the default-value or defined type.
>
> function foo(int $d =3D null) { var_dump($d); }
> foo(null); // And this should pass it through, providing the
> NULL-value in the function.
>
> function foo(int $d =3D 20) { var_dump($d); }
> foo( (int)null ); // This can provide 0 as the programmer forcing it
> to be an integer before putting it into this function-call.
>
> I would personally not like to give the user the option to set a
> null-value if it's not the default.
> But .. I don't wanna screw up your idea.
>
> Bye
> Simon
>

--0016368e1d5b5c8a7904bb0bfa23--