Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58844
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.182 as permitted sender)
Message-ID: <4F5D09E5.3040008@gmail.com>
Date: Sun, 11 Mar 2012 21:24:05 +0100
User-Agent: Thunderbird
MIME-Version: 1.0
To: Adam Harvey <aharvey@php.net>
CC: Remi Collet <remi@fedoraproject.org>, mike@php.net, 
 PHP Internals <internals@lists.php.net>
References: <4F54ED5B.2010101@fedoraproject.org> <4F54EF64.6040208@fedoraproject.org> <D4.72.15180.2C7685F4@pb1.pair.com> <4F58DA17.9030000@fedoraproject.org> <CADajX4D27zESa5m_6pwmyd-ZvKYhb8v0q9J=Dds=LCf4m5OwZQ@mail.gmail.com>
In-Reply-To: <CADajX4D27zESa5m_6pwmyd-ZvKYhb8v0q9J=Dds=LCf4m5OwZQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] hash / tiger regression in PHP 5.4.0
From: keisial@gmail.com (=?UTF-8?B?w4FuZ2VsIEdvbnrDoWxleg==?=)

On 09/03/12 02:05, Adam Harvey wrote:
> On 9 March 2012 00:11, Remi Collet <remi@fedoraproject.org> wrote:
>> Le 08/03/2012 09:03, Michael Wallner a écrit :
>>> Sorry for the delay, but I already explained the issue in
>>> the bug report: https://bugs.php.net/bug.php?id=61291
>> Thanks, for the explanation.
> I'm still concerned about the idea that the output of a hash function
> would change from one minor release to another, frankly, whether the
> old output was right or wrong. That seems like the sort of thing users
> would rely on being very, very stable.

It'd be worse to keep the wrong behavior, providing as tiger what it is not.
What can be done is to add a "tiger192,3-broken php5.4" hash for BC of
those which may have used the new one.
It's serious enough so I'd consider it a factor for a new minor in short
time,
but not for setting in stone a wrong behavior.