Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58809
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 209.85.214.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c81Mt9JWP74oStOwVP_p8ySUtPcTgFDq6cpfPPu9PFiQA@mail.gmail.com>
References: <CAAyV7nHOwCoci6W7-cvFEJi27Wz7qA-_0a6_qHVyzwkC6rjWQQ@mail.gmail.com>
	<CAF+90c81Mt9JWP74oStOwVP_p8ySUtPcTgFDq6cpfPPu9PFiQA@mail.gmail.com>
Date: Fri, 9 Mar 2012 09:36:16 +0100
Message-ID: <CAJWj5+H8w8MOb30b-+ijXpNr9COTVVe7kCMqf4uZpkyGCnL8SA@mail.gmail.com>
To: Nikita Popov <nikita.ppv@googlemail.com>
Cc: Anthony Ferrara <ircmaxell@gmail.com>, internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [POC - Patch] Scalar Type Hinting - A-La zend_parse_parameters
From: simonsimcity@googlemail.com (Simon Schick)

Hi, all

At first, many thanks to Anthony for writing the code!

2012/3/9 Anthony Ferrara <ircmaxell@gmail.com>
> fooi(1.5); // int(1)

Here an E_NOTICE would be a minimum as we are modifying the data. I'd
like to see an E_RECOVERABLE_ERROR as well. You should use
float-casting instead if you want to allow this as well.
And this should be the only difference between int and float. (Float
will of course also accept strings like "1.5")

One more question I have to raise here ... is ".5" a valid float? Or
do I have to change it to "0.5" to get it valid?

2012/3/9 Nikita Popov <nikita.ppv@googlemail.com>
>
> a) I'm not sure that we really want to accept '123abc' on an int cast
> with just a notice. In my eyes that is clearly malformed input, which
> should not be accepted.

In my opinion '123abc' is not a valid integer as well.

2012/3/9 Nikita Popov <nikita.ppv@googlemail.com>
>
> b) The bool cast rules also accept lots of input with dataloss. At
> least the fact that "abc" is considered a valid bool seems odd.

I think all values that are not castable to an integer 0 or 1 should
fail in Boolean.

I pretty much like the rest.
But as we are allowing classes implementing __toString() we should
also think about updating the array type-cast - but that's another
discussion that we can pick up later.

Bye
Simon