Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58808
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 209.85.215.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAAyV7nHOwCoci6W7-cvFEJi27Wz7qA-_0a6_qHVyzwkC6rjWQQ@mail.gmail.com>
References: <CAAyV7nHOwCoci6W7-cvFEJi27Wz7qA-_0a6_qHVyzwkC6rjWQQ@mail.gmail.com>
Date: Fri, 9 Mar 2012 09:10:56 +0100
Message-ID: <CAF+90c81Mt9JWP74oStOwVP_p8ySUtPcTgFDq6cpfPPu9PFiQA@mail.gmail.com>
To: Anthony Ferrara <ircmaxell@gmail.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [POC - Patch] Scalar Type Hinting - A-La zend_parse_parameters
From: nikita.ppv@googlemail.com (Nikita Popov)

On Fri, Mar 9, 2012 at 3:32 AM, Anthony Ferrara <ircmaxell@gmail.com> wrote=
:
> Hey all,
>
> As promised, I've created a POC patch to implement scalar type hints,
> the way that zend_parse_parameters handles hinting. =A0First off, here's
> the patch:
Thanks for all the hard work you're putting into this :)

> So, what do you think?
This is the proposal I like most. It allows for some type juggling,
but blocks off the ugly edge cases where dataloss would occur.

Thinking in that direction I'd say that the casting rules are still
too lax though:

a) I'm not sure that we really want to accept '123abc' on an int cast
with just a notice. In my eyes that is clearly malformed input, which
should not be accepted.

b) The bool cast rules also accept lots of input with dataloss. At
least the fact that "abc" is considered a valid bool seems odd.

Nikita