Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58807
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 209.85.215.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAJy+15yVQSXCaWOrLgSmM61UgJ0-B9eMK8LGw=mTpvgJECe_sg@mail.gmail.com>
References: <CAAyV7nHOwCoci6W7-cvFEJi27Wz7qA-_0a6_qHVyzwkC6rjWQQ@mail.gmail.com>
	<CAJy+15yVQSXCaWOrLgSmM61UgJ0-B9eMK8LGw=mTpvgJECe_sg@mail.gmail.com>
Date: Fri, 9 Mar 2012 08:51:51 +0100
Message-ID: <CAF+90c_v59-3jMrLseHXMjBb-OvRN9G1GcWgA4RW6BhwTMmECw@mail.gmail.com>
To: Ilia Alshanetsky <ilia@prohost.org>
Cc: Anthony Ferrara <ircmaxell@gmail.com>, internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [POC - Patch] Scalar Type Hinting - A-La zend_parse_parameters
From: nikita.ppv@googlemail.com (Nikita Popov)

On Fri, Mar 9, 2012 at 3:58 AM, Ilia Alshanetsky <ilia@prohost.org> wrote:
> Anthony,
>
> My concern with this type of patch is that what you are proposing are
> not really hints, they are forced casts. As such they modify the data
> potentially leading to data loss.
This patch specifically tries to overcome this problem of the previous
version. It will not accept input which will lead to a data loss on
cast. The only exception is passing "123abc" to an int hint, which
will cast to 123 and throw a notice. This is also my only point of
critique: I'd prefer to be stricter here and go all the way to a
recoverable fatal error.

Nikita