Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58806
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain rotorised.com from 203.88.115.241 cause and error)
Message-ID: <4F59A8A1.9090800@rotorised.com>
Date: Fri, 09 Mar 2012 16:52:17 +1000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
MIME-Version: 1.0
To: internals@lists.php.net
References: <CAAyV7nHOwCoci6W7-cvFEJi27Wz7qA-_0a6_qHVyzwkC6rjWQQ@mail.gmail.com>
In-Reply-To: <CAAyV7nHOwCoci6W7-cvFEJi27Wz7qA-_0a6_qHVyzwkC6rjWQQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [POC - Patch] Scalar Type Hinting - A-La zend_parse_parameters
From: lists@rotorised.com (Ryan McCue)

Anthony Ferrara wrote:
> So, what do you think?

I am a big fan of this style. Accepting e.g. "1abc" as int(1) with a 
notice seems like a better solution than anything else. A full error 
would be too much towards strict typing (I wouldn't mind personally, but 
others do have a strong opinion on this, as we've seen).

The only thing I'm not so crazy about is foob('abc') -> bool(true). I 
can live with it, but I don't particularly like it as far as the typing 
goes.


Ilia Alshanetsky wrote:
 > My concern with this type of patch is that what you are proposing are
 > not really hints, they are forced casts. As such they modify the data
 > potentially leading to data loss.

I disagree with Ilia on this, as the casts are only made if they can be 
converted properly, and give E_RECOVERABLE_ERROR instead. Anything 
that's going to have significant data loss is covered by that.


Bottom line: I'd personally use this, while I certainly would not use 
the previous style (with `(int) $foo` e.g.).

-- 
Ryan McCue
<http://ryanmccue.info/>