Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:58797 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 13893 invoked from network); 9 Mar 2012 01:06:21 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Mar 2012 01:06:21 -0000 Authentication-Results: pb1.pair.com smtp.mail=adam@adamharvey.name; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=adam@adamharvey.name; sender-id=pass Received-SPF: pass (pb1.pair.com: domain adamharvey.name designates 209.85.210.170 as permitted sender) X-PHP-List-Original-Sender: adam@adamharvey.name X-Host-Fingerprint: 209.85.210.170 mail-iy0-f170.google.com Received: from [209.85.210.170] ([209.85.210.170:37827] helo=mail-iy0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 23/60-10820-A87595F4 for ; Thu, 08 Mar 2012 20:06:18 -0500 Received: by iaeh11 with SMTP id h11so1685260iae.29 for ; Thu, 08 Mar 2012 17:06:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamharvey.name; s=google; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=mNpVzIWDdGW7/EnKnW3BmTGTz3ag94+8EKzdtSu/Wcg=; b=h+gZnhSO5WwKZtpFnlIqV7KU+AJZoeNebaKkM6ZoXuQpayqemie8t9Q9Tnhv7OiXC1 r1FaAU689V0PdYXJ6tCmOd4EqxocPBIejYHfbnYqj3q/pxdEMEPAdcZza4eC6/eFoyed g8e5P33NslQnJNrOMwDCB7E5sje+veAWx6+kY= Received: by 10.50.87.229 with SMTP id bb5mr20412614igb.33.1331255175420; Thu, 08 Mar 2012 17:06:15 -0800 (PST) MIME-Version: 1.0 Sender: adam@adamharvey.name Received: by 10.43.52.137 with HTTP; Thu, 8 Mar 2012 17:05:55 -0800 (PST) In-Reply-To: <4F58DA17.9030000@fedoraproject.org> References: <4F54ED5B.2010101@fedoraproject.org> <4F54EF64.6040208@fedoraproject.org> <4F58DA17.9030000@fedoraproject.org> Date: Fri, 9 Mar 2012 09:05:55 +0800 X-Google-Sender-Auth: 0fKQKyBBOG_Qf7Im1QyGMZ-aCaI Message-ID: To: Remi Collet , mike@php.net Cc: PHP Internals Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQmlcay8zUy91YbbF1C08D4tJYODK44BK3xgryo+SlA8pwxqd6uvGZN26FXKVd+MxjFxU55+ Subject: Re: [PHP-DEV] hash / tiger regression in PHP 5.4.0 From: aharvey@php.net (Adam Harvey) On 9 March 2012 00:11, Remi Collet wrote: > Le 08/03/2012 09:03, Michael Wallner a =C3=A9crit : >> Sorry for the delay, but I already explained the issue in >> the bug report: https://bugs.php.net/bug.php?id=3D61291 > > Thanks, for the explanation. I'm still concerned about the idea that the output of a hash function would change from one minor release to another, frankly, whether the old output was right or wrong. That seems like the sort of thing users would rely on being very, very stable. > But mhash_001.phpt and mhash_003.phpt should not fail > (if we want a great PHP with 0 test failed). > > As this tests seems to be old ones from old mhash extension, > they probably should be tagged as "expected failed" with a message such > as "Compatibility break with php < 5.4.0" Agreed. I'm happy to mark them as XFAIL if that's what's expected. Mike? Adam