Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:58786 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 52822 invoked from network); 8 Mar 2012 16:11:59 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Mar 2012 16:11:59 -0000 Authentication-Results: pb1.pair.com smtp.mail=remi@fedoraproject.org; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=remi@fedoraproject.org; sender-id=unknown Received-SPF: error (pb1.pair.com: domain fedoraproject.org from 217.70.183.196 cause and error) X-PHP-List-Original-Sender: remi@fedoraproject.org X-Host-Fingerprint: 217.70.183.196 relay4-d.mail.gandi.net Linux 2.6 Received: from [217.70.183.196] ([217.70.183.196:53813] helo=relay4-d.mail.gandi.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D6/D8-00152-D4AD85F4 for ; Thu, 08 Mar 2012 11:11:57 -0500 X-Originating-IP: 217.70.178.148 Received: from mfilter20-d.gandi.net (mfilter20-d.gandi.net [217.70.178.148]) by relay4-d.mail.gandi.net (Postfix) with ESMTP id 93D5A17209C for ; Thu, 8 Mar 2012 17:11:54 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter20-d.gandi.net Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by mfilter20-d.gandi.net (mfilter20-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id iuY0iIYgCxWk for ; Thu, 8 Mar 2012 17:11:53 +0100 (CET) X-Originating-IP: 82.241.130.121 Received: from verne.famillecollet.com (pom51-2-82-241-130-121.fbx.proxad.net [82.241.130.121]) (Authenticated sender: remicollet@famillecollet.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPA id 1652717209D for ; Thu, 8 Mar 2012 17:11:52 +0100 (CET) Message-ID: <4F58DA17.9030000@fedoraproject.org> Date: Thu, 08 Mar 2012 17:11:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120218 Thunderbird/10.0.2 MIME-Version: 1.0 To: PHP Internals References: <4F54ED5B.2010101@fedoraproject.org> <4F54EF64.6040208@fedoraproject.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] hash / tiger regression in PHP 5.4.0 From: remi@fedoraproject.org (Remi Collet) Le 08/03/2012 09:03, Michael Wallner a =C3=A9crit : > On Mon, 05 Mar 2012 17:52:52 +0100, Remi Collet wrote: >=20 >> >> Using a simple C program (linked against libmash) >> >> Hash: fdb9019a79c33a95677e2097abae91eb0de00b3054bb5c39 >> >> So the result from php <=3D 5.3.10 seems the right one. >=20 > Sorry for the delay, but I already explained the issue in > the bug report: https://bugs.php.net/bug.php?id=3D61291 Thanks, for the explanation. I raised this issue, because of 2 failing tests. Another test (because Interoperability seems important) $ perl -e 'use Digest::Tiger;my $hexhash =3D Digest::Tiger::hexhash("");print $hexhash."\n";' 3293AC630C13F0245F92BBB1766E16167A4E58492DDE73F3 $ php -r 'echo hash("tiger192,3", "")."\n";' 3293ac630c13f0245f92bbb1766e16167a4e58492dde73f3 So, this seems ok. But mhash_001.phpt and mhash_003.phpt should not fail (if we want a great PHP with 0 test failed). As this tests seems to be old ones from old mhash extension, they probably should be tagged as "expected failed" with a message such as "Compatibility break with php < 5.4.0" Best regards. >=20 > Thanks anyway, > Mike >=20 >=20