Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:58568 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 83132 invoked from network); 4 Mar 2012 13:29:52 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Mar 2012 13:29:52 -0000 Authentication-Results: pb1.pair.com header.from=ircmaxell@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ircmaxell@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.173 as permitted sender) X-PHP-List-Original-Sender: ircmaxell@gmail.com X-Host-Fingerprint: 209.85.216.173 mail-qy0-f173.google.com Received: from [209.85.216.173] ([209.85.216.173:43546] helo=mail-qy0-f173.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 96/D9-12048-F4E635F4 for ; Sun, 04 Mar 2012 08:29:51 -0500 Received: by qcsc20 with SMTP id c20so1451869qcs.18 for ; Sun, 04 Mar 2012 05:29:49 -0800 (PST) Received-SPF: pass (google.com: domain of ircmaxell@gmail.com designates 10.224.182.201 as permitted sender) client-ip=10.224.182.201; Authentication-Results: mr.google.com; spf=pass (google.com: domain of ircmaxell@gmail.com designates 10.224.182.201 as permitted sender) smtp.mail=ircmaxell@gmail.com; dkim=pass header.i=ircmaxell@gmail.com Received: from mr.google.com ([10.224.182.201]) by 10.224.182.201 with SMTP id cd9mr1006272qab.92.1330867789319 (num_hops = 1); Sun, 04 Mar 2012 05:29:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=81fwKZ76ae11Yj7LBioWAmjO1YzKYcw+hjWkw4aVFoU=; b=qJR+lckdSSQrYDmKJcQxKFTgr0XEOgdJsTPnD++Fd3gqt9Zz0RQr0nGsth9CxysJ59 XGJ3iPG3b93XlSsA+K9jVTdzKQx1rZk1pbyfpNqsg9ZbbzGEcV3LYH3qv0HU5LLqj9Yz 5rfTZu35/++i7UYDncoY3pJDzIxz/CCAyqrLUeQSB8ZhG8vickEXHpQjq2HO/87mHeZc Wp2K+zfFvQecBe0s7Ezlwp6ekdNF3RPabPHfsSY89ioV2pKmbE1sKX7FycLIvpPMbpUR 76fEtZqmqy2cjwhbXnBoI9BCVp6SzKFr4kZTDsR3rd7ZajY8y8xSdTHgA5bOaOH35vz7 kCGA== MIME-Version: 1.0 Received: by 10.224.182.201 with SMTP id cd9mr901830qab.92.1330867789124; Sun, 04 Mar 2012 05:29:49 -0800 (PST) Received: by 10.229.49.74 with HTTP; Sun, 4 Mar 2012 05:29:49 -0800 (PST) Date: Sun, 4 Mar 2012 08:29:49 -0500 Message-ID: To: internals@lists.php.net Content-Type: text/plain; charset=ISO-8859-1 Subject: Patches for Review From: ircmaxell@gmail.com (Anthony Ferrara) Hey all, I had messaged about these patches before, but with the 5.4 release process happening I think it slipped through the cracks. I have 3 patches that are ready for inclusion... https://bugs.php.net/bug.php?id=60813 Adding a new hash_pbkdf2() function to allow for a C level implementation of the PKCS5 recomended password key stretching algorithm. https://bugs.php.net/bug.php?id=60789 Bringing pow() inline with docs in that it will attempt to return an integer (by casting one or more of the arguments to int) if possible. This fixes a precision loss that can occur with float arguments that are exactly integers on 64 bit platforms. https://bugs.php.net/bug.php?id=60596 A little code-cleanup to remove a superfluous if statement in a switch in the spl_offset_convert_to_long function... If anyone can commit these, if I can be granted the Karma to commit them. of if anyone can comment as to why they should not be committed, that would be great. Thanks, Anthony