Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58255
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain punkave.com designates 209.85.210.170 as permitted sender)
Received-SPF: pass (google.com: domain of tom@punkave.com designates 10.50.216.231 as permitted sender) client-ip=10.50.216.231;
MIME-Version: 1.0
In-Reply-To: <CAGSj+QuiRojiYnzbE495EGaS_ZjBZF6y47SVL6tBFOBkFKtp+A@mail.gmail.com>
References: <01a901ccf622$0645f230$12d1d690$@alliantinternet.com>
	<CAGSj+QtVWzc50kZX=0q-CRukd73eZ1T0B9D8t7EejXMw_9Q4ZQ@mail.gmail.com>
	<fd6fc5212ceab7a265cb505039373a0d.squirrel@www.l-i-e.com>
	<CAL0xaBHDu3xNwdO7XwCRObXTZd_X192KgxAoFH_ZH2TTsPGZ6Q@mail.gmail.com>
	<CAGSj+QuiRojiYnzbE495EGaS_ZjBZF6y47SVL6tBFOBkFKtp+A@mail.gmail.com>
Date: Tue, 28 Feb 2012 11:48:27 -0500
Message-ID: <CAORXhGJuhaLMvmu0_6fH7zZTXEJyrgwoMBRnBQi-7XSrtKX-_w@mail.gmail.com>
To: Kiall Mac Innes <kiall@managedit.ie>
Cc: Arvids Godjuks <arvids.godjuks@gmail.com>, Richard Lynch <ceo@l-i-e.com>, internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Possibility to add finally to try/catch?
From: tom@punkave.com (Tom Boutell)

On Tue, Feb 28, 2012 at 11:32 AM, Kiall Mac Innes <kiall@managedit.ie> wrot=
e:
> Yes, You could abstract the try/catch into a new (and un-needed) function
> to try and emulate the behavior of finally.. Unless, for example, you
> re-throw the exception after logging in the catch.

'finally' doesn't run for stuff that throws an exception not caught in
the try { } block, or an exception thrown again in the catch { } block
- does it?

I would hope not, since that means "something this block of code did
not anticipate at all - another sort of exceptional situation
altogether" and really should not run any more local code, nothing
until and unless there is a catch block somewhere further up that does
catch that exception.

Assuming I'm right and 'finally' runs only for normal completion and
for exceptions actually caught by the catch { } block attached to the
same try { }, then my refactoring still behaves exactly like
'finally'.

I am not convinced the function is unnecessary, either. Decomposition
is usually a good idea (:

> substitute for a native language construct
>
> try {
> =A0 =A0$fh =3D fopen($filename);
>
> =A0 =A0// Do some work on the file + encounter an error.
> =A0 =A0throw new Exception();
> } catch (Exception $e) {
> =A0 =A0$log->add(Log::ERROR, "Something went wrong", $e);
>
> =A0 =A0throw $e;
> } finally {
> =A0 =A0fclose($fh);
> }
>
> Thanks,
> Kiall
>
>
> On Tue, Feb 28, 2012 at 4:12 PM, Arvids Godjuks <arvids.godjuks@gmail.com=
>wrote:
>
>> It's quite hard to think of a compelling example. Usually you just
>> write the code and realize that "Yea, a 'finally' statement would make
>> a lot of sense here".
>> I believe it's the kind of functionality that you learn to use in
>> time, just like __set, __get, __sleep, __wakeup. If first two are no
>> brainier these days, the last two to me where "wtf? does anyone use
>> that? Where I need them at all?!". It was like that for 3-4 years.
>> Until I got the code witch actually made an active use of these two
>> and I understood the purpose.
>> Same goes to finally. I remember using in JavaScript a few times, helped=
 a
>> lot.
>> And it just makes sense to add to complete the try {} catch {} finally
>> {} template.
>> My 2 cents.
>>
>> 2012/2/28 Richard Lynch <ceo@l-i-e.com>:
>> > On Tue, February 28, 2012 8:22 am, Kiall Mac Innes wrote:
>> >> +1000
>> >>
>> >> This is a feature that I've always wanted in PHP, My main reason bein=
g
>> >> to
>> >> reduce code duplication. eg
>> >>
>> >> try {
>> >> =A0 =A0 $fh =3D fopen($filename);
>> >>
>> >> =A0 =A0 // Do some work on the file + encounter an error.
>> >> =A0 =A0 throw new Exception();
>> >> } catch (Exception $e) {
>> >> =A0 =A0 // Log an error or something
>> > + =A0 =A0 =A0 if ($fh) fclose($fh); //many PHP file errors NULL out th=
e $fh
>> > + =A0}
>> > - > } finally {
>> > - > =A0 =A0 fclose($fh);
>> > - > }
>> >
>> > Another non-compelling example...
>> >
>> > Still not saying "finally" is a bad idea.
>> >
>> > Just want a compelling use case before I would vote...
>> >
>> > --
>> > brain cancer update:
>> > http://richardlynch.blogspot.com/search/label/brain%20tumor
>> > Donate:
>> >
>> https://www.paypal.com/cgi-bin/webscr?cmd=3D_s-xclick&hosted_button_id=
=3DFS9NLTNEEKWBE
>> >
>> >
>> >
>> > --
>> > PHP Internals - PHP Runtime Development Mailing List
>> > To unsubscribe, visit: http://www.php.net/unsub.php
>> >
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>



--=20
Tom Boutell
P'unk Avenue
215 755 1330
punkave.com
window.punkave.com