Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58254
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain managedit.ie designates 209.85.214.42 as permitted sender)
Received-SPF: pass (google.com: domain of kiall@managedit.ie designates 10.204.136.207 as permitted sender) client-ip=10.204.136.207;
MIME-Version: 1.0
In-Reply-To: <CAL0xaBHDu3xNwdO7XwCRObXTZd_X192KgxAoFH_ZH2TTsPGZ6Q@mail.gmail.com>
References: <01a901ccf622$0645f230$12d1d690$@alliantinternet.com>
 <CAGSj+QtVWzc50kZX=0q-CRukd73eZ1T0B9D8t7EejXMw_9Q4ZQ@mail.gmail.com>
 <fd6fc5212ceab7a265cb505039373a0d.squirrel@www.l-i-e.com> <CAL0xaBHDu3xNwdO7XwCRObXTZd_X192KgxAoFH_ZH2TTsPGZ6Q@mail.gmail.com>
Date: Tue, 28 Feb 2012 16:32:11 +0000
Message-ID: <CAGSj+QuiRojiYnzbE495EGaS_ZjBZF6y47SVL6tBFOBkFKtp+A@mail.gmail.com>
To: Arvids Godjuks <arvids.godjuks@gmail.com>
Cc: Richard Lynch <ceo@l-i-e.com>, internals@lists.php.net
Content-Type: multipart/alternative; boundary=0015175cfa3402af2604ba08c6f9
Subject: Re: [PHP-DEV] Possibility to add finally to try/catch?
From: kiall@managedit.ie (Kiall Mac Innes)

--0015175cfa3402af2604ba08c6f9
Content-Type: text/plain; charset=ISO-8859-1

Completely agree - finally comes into its own in more complex code, the
kind of code that is quite hard to distill into a few line "compelling
example".

Yes, You could abstract the try/catch into a new (and un-needed) function
to try and emulate the behavior of finally.. Unless, for example, you
re-throw the exception after logging in the catch. But - This really is no
substitute for a native language construct

try {
    $fh = fopen($filename);

    // Do some work on the file + encounter an error.
    throw new Exception();
} catch (Exception $e) {
    $log->add(Log::ERROR, "Something went wrong", $e);

    throw $e;
} finally {
    fclose($fh);
}

Thanks,
Kiall


On Tue, Feb 28, 2012 at 4:12 PM, Arvids Godjuks <arvids.godjuks@gmail.com>wrote:

> It's quite hard to think of a compelling example. Usually you just
> write the code and realize that "Yea, a 'finally' statement would make
> a lot of sense here".
> I believe it's the kind of functionality that you learn to use in
> time, just like __set, __get, __sleep, __wakeup. If first two are no
> brainier these days, the last two to me where "wtf? does anyone use
> that? Where I need them at all?!". It was like that for 3-4 years.
> Until I got the code witch actually made an active use of these two
> and I understood the purpose.
> Same goes to finally. I remember using in JavaScript a few times, helped a
> lot.
> And it just makes sense to add to complete the try {} catch {} finally
> {} template.
> My 2 cents.
>
> 2012/2/28 Richard Lynch <ceo@l-i-e.com>:
> > On Tue, February 28, 2012 8:22 am, Kiall Mac Innes wrote:
> >> +1000
> >>
> >> This is a feature that I've always wanted in PHP, My main reason being
> >> to
> >> reduce code duplication. eg
> >>
> >> try {
> >>     $fh = fopen($filename);
> >>
> >>     // Do some work on the file + encounter an error.
> >>     throw new Exception();
> >> } catch (Exception $e) {
> >>     // Log an error or something
> > +       if ($fh) fclose($fh); //many PHP file errors NULL out the $fh
> > +  }
> > - > } finally {
> > - >     fclose($fh);
> > - > }
> >
> > Another non-compelling example...
> >
> > Still not saying "finally" is a bad idea.
> >
> > Just want a compelling use case before I would vote...
> >
> > --
> > brain cancer update:
> > http://richardlynch.blogspot.com/search/label/brain%20tumor
> > Donate:
> >
> https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=FS9NLTNEEKWBE
> >
> >
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--0015175cfa3402af2604ba08c6f9--