Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58242
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain punkave.com designates 209.85.213.42 as permitted sender)
Received-SPF: pass (google.com: domain of tom@punkave.com designates 10.50.161.170 as permitted sender) client-ip=10.50.161.170;
MIME-Version: 1.0
In-Reply-To: <CAKxcST8pW=jR0_th+FzMYvQ3St+Pjkd4kSNbFVYMNR569wJZmw@mail.gmail.com>
References: <01a901ccf622$0645f230$12d1d690$@alliantinternet.com>
	<CAGSj+QtVWzc50kZX=0q-CRukd73eZ1T0B9D8t7EejXMw_9Q4ZQ@mail.gmail.com>
	<CAKxcST8pW=jR0_th+FzMYvQ3St+Pjkd4kSNbFVYMNR569wJZmw@mail.gmail.com>
Date: Tue, 28 Feb 2012 09:45:59 -0500
Message-ID: <CAORXhGKZsvh0_QKN_Xy3kEJF+zSNFpLGX4wXVa4O6U6C0rMAOg@mail.gmail.com>
To: Paul Dragoonis <dragoonis@gmail.com>
Cc: Kiall Mac Innes <kiall@managedit.ie>, Dmitri Snytkine <dsnytkine@ultralogistics.com>, 
	internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Possibility to add finally to try/catch?
From: tom@punkave.com (Tom Boutell)

In many cases this can be done by refactoring to a method:

public function main()
{
  $in =3D fopen('whatever');
  $this->whereTheStuffWent($in);
  fclose($in);
}

protected function whereTheStuffWent($in)
{
  try {
    // Do stuff that might throw an exception
  } catch (Exception $e)
  {
    // Log it or something
  }
}

The while loop case in https://bugs.php.net/bug.php?id=3D36779 could be
dealt with by returning a result from whereTheStuffWent and breaking
out if it's set. Not too bad. finally { } might be a little more
convenient than this I suppose:

$finished =3D $this->whereTheStuffWent($in);
fclose($in);
if ($finished)
{
  break;
}


On Tue, Feb 28, 2012 at 9:25 AM, Paul Dragoonis <dragoonis@gmail.com> wrote=
:
> Tried to do something the other day and had to write something a bit quir=
ky
> tht would have been super clean with a finally block.
>
> +1000
>
> On Tue, Feb 28, 2012 at 2:22 PM, Kiall Mac Innes <kiall@managedit.ie> wro=
te:
>
>> +1000
>>
>> This is a feature that I've always wanted in PHP, My main reason being t=
o
>> reduce code duplication. eg
>>
>> try {
>> =A0 =A0$fh =3D fopen($filename);
>>
>> =A0 =A0// Do some work on the file + encounter an error.
>> =A0 =A0throw new Exception();
>> } catch (Exception $e) {
>> =A0 =A0// Log an error or something
>> } finally {
>> =A0 =A0fclose($fh);
>> }
>>
>> Thanks,
>> Kiall
>>
>>
>> On Tue, Feb 28, 2012 at 2:05 PM, Dmitri Snytkine <
>> dsnytkine@ultralogistics.com> wrote:
>>
>> >
>> > This is another feature that we know we can live without
>> > but those familiar with languages that have 'finally' like Java or Pyt=
hon
>> > know that
>> > it is very neat feature to have in some situations.
>> >
>> > Basically the code inside 'finally' is guaranteed to run even if there
>> is a
>> > 'return' inside try or catch blocks
>> > in which case the value to be returned is remembered tempraraly, the c=
ode
>> > inside finally block executes and then remembered value is returned.
>> >
>> >
>> > Dmitri Snytkine
>> > Web Developer
>> > Ultra Logistics, Inc.
>> > Phone: (888) 220-4640 x 2097
>> > Fax: (888) 795-6642
>> > E-Mail: dsnytkine@ultralogistics.com
>> > Web: www.ultralogistics.com
>> >
>> > "A Top 100 Logistics I.T. Provider in 2011"
>> >
>> >
>> >
>> >
>> > --
>> > PHP Internals - PHP Runtime Development Mailing List
>> > To unsubscribe, visit: http://www.php.net/unsub.php
>> >
>> >
>>



--=20
Tom Boutell
P'unk Avenue
215 755 1330
punkave.com
window.punkave.com