Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:58058
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain oracle.com from 141.146.126.227 cause and error)
Message-ID: <4F482E58.9020802@oracle.com>
Date: Fri, 24 Feb 2012 16:42:00 -0800
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0) Gecko/20120129 Thunderbird/10.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <CAKOpQSwMkn=0cQh9cupj-8qihVvhEEOY-kqQ0F4pLb4J1MfuZA@mail.gmail.com> <a0f321a49cb0932bde8bba4adc890bca.squirrel@www.l-i-e.com> <CAKOpQSwYa89n3s8FzytQ49i8MqUA9sFsQRh+enGzADg=h4A4xg@mail.gmail.com> <4F481E93.1090400@oracle.com> <CAKOpQSzRdjqThrTb6JeEzhnKmg_85WKejicN1rhMp49+v6cjHg@mail.gmail.com> <4F482524.6060106@oracle.com> <CAKOpQSyn8LtbBWor5ywo=hLkauSECf6shEvp9LKcrXcb9ZRnZA@mail.gmail.com>
In-Reply-To: <CAKOpQSyn8LtbBWor5ywo=hLkauSECf6shEvp9LKcrXcb9ZRnZA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] APXS LoadModule Option in configure
From: christopher.jones@oracle.com (Christopher Jones)



On 02/24/2012 04:14 PM, Kris Craig wrote:
> No, it happens and it's even clearly documented in APXS.
>
> Basically, if you specify the "-a" option in APXS, it overwrites your
> httpd.conf (or apache.conf or whatever it is on your system) and adds the
> LoadModule line to it.  In PHP's configure script, you'll notice that "-a"
> is always specified; there's no option to use APXS without it.  As a
> result, "make install" will always overwrite your LoadModule entry in
> httpd.conf if APXS is enabled.  The problem occurs when you have LoadModule
> in an included .conf file already; APXS does not have the ability to detect
> that.  Therefore, a "duplicate" LoadModule entry is added to httpd.conf by
> APXS, and thus the clash occurs.  This behavior has been reproduced
> numerous times.

I can start with a LoadModule line, run the exact apxs command that
the PHP Makefile executes and I still have only one LoadModule in the
file.  Note the time stamp of the file changes.

   cjones:~/phpbuild/php53 $ ls -l /home/cjones/apache22/conf/httpd.conf
   -rw-r--r-- 1 cjones cjones 13998 2012-02-24 16:30 /home/cjones/apache22/conf/httpd.conf

   cjones:~/phpbuild/php53 $ grep libphp5 /home/cjones/apache22/conf/httpd.conf
   LoadModule php5_module        modules/libphp5.so

   cjones:~/phpbuild/php53 $ /home/cjones/apache22/bin/apxs -S LIBEXECDIR=/home/cjones/apache22/modules -S SYSCONFDIR=/home/cjones/apache22/conf -i -a -n php5 libphp5.la
   /home/cjones/apache22/build/instdso.sh SH_LIBTOOL='/home/cjones/apache22/build/libtool' libphp5.la /home/cjones/apache22/modules
   /home/cjones/apache22/build/libtool --mode=install cp libphp5.la /home/cjones/apache22/modules/
   cp .libs/libphp5.so /home/cjones/apache22/modules/libphp5.so
   cp .libs/libphp5.lai /home/cjones/apache22/modules/libphp5.la
   libtool: install: warning: remember to run `libtool --finish /home/cjones/phpbuild/php53 /libs'
   chmod 755 /home/cjones/apache22/modules/libphp5.so
   [activating module `php5' in /home/cjones/apache22/conf/httpd.conf]

   cjones:~/phpbuild/php53 $ ls -l /home/cjones/apache22/conf/httpd.conf
   -rw-r--r-- 1 cjones cjones 13998 2012-02-24 16:33 /home/cjones/apache22/conf/httpd.conf

   cjones:~/phpbuild/php53 $ grep libphp5 /home/cjones/apache22/conf/httpd.conf
   LoadModule php5_module        modules/libphp5.so

I could interpolate the "apxs -a" documentation that says "or by
enabling it if it already exists" to support what I see.

Good luck with your RFC,

Chris

-- 
Email: christopher.jones@oracle.com
Tel:  +1 650 506 8630
Blog:  http://blogs.oracle.com/opal/