Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57897
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.210.42 cause and error)
Received-SPF: pass (google.com: domain of rasmus@lerdorf.com designates 10.68.241.39 as permitted sender) client-ip=10.68.241.39;
Message-ID: <4F3ECDB8.6030405@lerdorf.com>
Date: Fri, 17 Feb 2012 13:59:20 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111229 Thunderbird/9.0
MIME-Version: 1.0
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: max_file_uploads INI_PERDIR
From: rasmus@lerdorf.com (Rasmus Lerdorf)

I'd like to add PHP_INI_PERDIR to max_file_uploads before 5.4.0 and also
in the next 5.3 release. This setting is very similar in scope to
max_input_vars and other POST-related limiters like upload_max_filesize,
and post_max_size all of which are PHP_INI_SYSTEM|PHP_INI_PERDIR.

The main reason is that our default for max_file_uploads is rather low
and since we count empty uploads against this limit it is easy for apps
to hit this. So if you have more than 20 type="file" fields in a form,
even if the user only actually uploads a single file, it will hit this
limit and fail.

The change it trivial and since it eases a restriction and doesn't
tighten one, it isn't going to break anything:

http://svn.php.net/viewvc/php/php-src/trunk/main/main.c?r1=323245&r2=323296

Any objections from anyone?
Stas on the 5.4.0 merge?
Johannes on the 5.3.11?

One example of pain this is currently causing:
   http://allinthehead.com/retro/349/the-curse-of-max_file_uploads

-Rasmus