Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57814
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.199.177.89 as permitted sender)
Message-ID: <4F38AE39.8000708@zend.com>
Date: Mon, 13 Feb 2012 10:31:21 +0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0
MIME-Version: 1.0
To: yoram bar haim <yoram.b@zend.com>
CC: PHP Internals <internals@lists.php.net>, Alex Haiut <alex.h@zend.com>,
	Zeev Suraski <zeev@zend.com>, Eran Ifrah <eran@zend.com>, Lior Kaplan
	<lior.k@zend.com>
References: <201202121409.54891.yoram.b@zend.com>
In-Reply-To: <201202121409.54891.yoram.b@zend.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: restore user opcode handler in PHP
From: dmitry@zend.com (Dmitry Stogov)

Hi Yoram,

Can we just fill this arrays with zeros on php startup?

Thanks. Dmitry.

On 02/12/2012 04:09 PM, yoram bar haim wrote:
> I first saw this problem while addapting extension to PHP 5.4 but the code is
> the same in 5.3 :
> when you call zend_set_user_opcode_handler() it set's a pointer (handler) in
> zend_user_opcode_handlers and a uint opcode value in zend_user_opcodes to
> ZEND_USER_OPCODE .
>
> you can call zend_set_user_opcode_handler with the original handler to restore
> it, but if the original state did not include ZEND_USER_OPCODE you have no way
> to restore it.
>
> Why restoring ?
> On mac, static variables are not re-initialized on dlclose()+dlopen(). that
> means that apache reload does not re-create zend_user_opcode_handlers and
> zend_user_opcodes.
> if your extension sets user_opcode_handler and is not reloaded in apache
> reload (because you commented it in php.ini, for example), your handlers array
> will actually point to non-exist handler.
> if you will call zend_set_user_opcode_handler() with the original handler at
> MSHUTDOWN, it will restore the handler but zend_user_opcodes[<opcode] will
> still be ZEND_USER_OPCODE so you will end up calling a NULL handler.
>
> we should eather allow zend_set_user_opcode_handler to also set the value in
> zend_user_opcodes[<opcode>] or we should build those arrayes from scratch at
> php_module_init.
>
> currently an extension tha calls zend_set_user_opcode_handler() will make PHP
> crash on mac after disabling the extension and apache reload.