Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57809
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.170 as permitted sender)
MIME-Version: 1.0
Sender: laruence@gmail.com
In-Reply-To: <201202121409.54891.yoram.b@zend.com>
References: <201202121409.54891.yoram.b@zend.com>
Date: Sun, 12 Feb 2012 20:41:44 +0800
Message-ID: <CABBJUpcFBFi1T4xWpuj5+kJbPYjQwYWe_sa5824NVcSggUB1oA@mail.gmail.com>
To: yoram bar haim <yoram.b@zend.com>
Cc: PHP Internals <internals@lists.php.net>, Dmitry Stogov <dmitry@zend.com>, 
	Alex Haiut <alex.h@zend.com>, Zeev Suraski <zeev@zend.com>, Eran Ifrah <eran@zend.com>, 
	Lior Kaplan <lior.k@zend.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] restore user opcode handler in PHP
From: laruence@php.net (Laruence)

Hi:
  could you file a feature req on bugs.php.net?

  I think it's okey to add a zend_restore_user_handler .

  like:

  ZEND_API int zend_restore_user_opcode_handler(zend_uchar opcode) {
    zend_user_opcodes[opcode] =3D opcode;
    zend_user_opcode_handlers[opcode] =3D NULL;
    return SUCCESS;
  }

  but it still need dmitry to review  :)

 thanks

On Sun, Feb 12, 2012 at 8:09 PM, yoram bar haim <yoram.b@zend.com> wrote:
> I first saw this problem while addapting extension to PHP 5.4 but the cod=
e is
> the same in 5.3 :
> when you call zend_set_user_opcode_handler() it set's a pointer (handler)=
 in
> zend_user_opcode_handlers and a uint opcode value in zend_user_opcodes to
> ZEND_USER_OPCODE .
>
> you can call zend_set_user_opcode_handler with the original handler to re=
store
> it, but if the original state did not include ZEND_USER_OPCODE you have n=
o way
> to restore it.
>
> Why restoring ?
> On mac, static variables are not re-initialized on dlclose()+dlopen(). th=
at
> means that apache reload does not re-create zend_user_opcode_handlers and
> zend_user_opcodes.
> if your extension sets user_opcode_handler and is not reloaded in apache
> reload (because you commented it in php.ini, for example), your handlers =
array
> will actually point to non-exist handler.
> if you will call zend_set_user_opcode_handler() with the original handler=
 at
> MSHUTDOWN, it will restore the handler but zend_user_opcodes[<opcode] wil=
l
> still be ZEND_USER_OPCODE so you will end up calling a NULL handler.
>
> we should eather allow zend_set_user_opcode_handler to also set the value=
 in
> zend_user_opcodes[<opcode>] or we should build those arrayes from scratch=
 at
> php_module_init.
>
> currently an extension tha calls zend_set_user_opcode_handler() will make=
 PHP
> crash on mac after disabling the extension and apache reload.
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>



--=20
Laruence =C2=A0Xinchen Hui
http://www.laruence.com/