Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57808
Return-Path: <yoram.b@zend.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 1096 invoked from network); 12 Feb 2012 12:10:06 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 12 Feb 2012 12:10:06 -0000
Authentication-Results: pb1.pair.com smtp.mail=yoram.b@zend.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=yoram.b@zend.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.199.177.89 as permitted sender)
X-PHP-List-Original-Sender: yoram.b@zend.com
X-Host-Fingerprint: 212.199.177.89 il-mr1.zend.com  
Received: from [212.199.177.89] ([212.199.177.89:43562] helo=il-mr1.zend.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 74/93-63294-C1CA73F4 for <internals@lists.php.net>; Sun, 12 Feb 2012 07:10:05 -0500
Received: from il-gw1.zend.com (unknown [10.1.1.22])
	by il-mr1.zend.com (Postfix) with ESMTP id 5E3C260774
	for <internals@lists.php.net>; Sun, 12 Feb 2012 14:08:27 +0200 (IST)
Received: from mandor.localnet (10.1.3.58) by il-ex2.zend.net (10.1.1.22) with
 Microsoft SMTP Server (TLS) id 14.1.255.0; Sun, 12 Feb 2012 14:09:51 +0200
To: PHP Internals <internals@lists.php.net>, Dmitry Stogov <dmitry@zend.com>,
	Alex Haiut <alex.h@zend.com>, Zeev Suraski <zeev@zend.com>, Eran Ifrah
	<eran@zend.com>, Lior Kaplan <lior.k@zend.com>
Date: Sun, 12 Feb 2012 14:09:54 +0200
User-Agent: KMail/1.13.7 (Linux/2.6.37; KDE/4.7.2; i686; ; )
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-ID: <201202121409.54891.yoram.b@zend.com>
X-Originating-IP: [10.1.3.58]
Subject: restore user opcode handler in PHP
From: yoram.b@zend.com (yoram bar haim)

I first saw this problem while addapting extension to PHP 5.4 but the code is 
the same in 5.3 :
when you call zend_set_user_opcode_handler() it set's a pointer (handler) in 
zend_user_opcode_handlers and a uint opcode value in zend_user_opcodes to 
ZEND_USER_OPCODE .

you can call zend_set_user_opcode_handler with the original handler to restore 
it, but if the original state did not include ZEND_USER_OPCODE you have no way 
to restore it.

Why restoring ?
On mac, static variables are not re-initialized on dlclose()+dlopen(). that 
means that apache reload does not re-create zend_user_opcode_handlers and 
zend_user_opcodes.
if your extension sets user_opcode_handler and is not reloaded in apache 
reload (because you commented it in php.ini, for example), your handlers array 
will actually point to non-exist handler.
if you will call zend_set_user_opcode_handler() with the original handler at 
MSHUTDOWN, it will restore the handler but zend_user_opcodes[<opcode] will 
still be ZEND_USER_OPCODE so you will end up calling a NULL handler.

we should eather allow zend_set_user_opcode_handler to also set the value in 
zend_user_opcodes[<opcode>] or we should build those arrayes from scratch at 
php_module_init.

currently an extension tha calls zend_set_user_opcode_handler() will make PHP 
crash on mac after disabling the extension and apache reload.