Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57806
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain easen.co.uk from 74.125.82.170 cause and error)
Message-ID: <4F343C47.1020304@easen.co.uk>
Date: Thu, 09 Feb 2012 21:36:07 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120129 Thunderbird/10.0
MIME-Version: 1.0
To: internals PHP <internals@lists.php.net>
Content-Type: multipart/alternative;
 boundary="------------070504050908060706030700"
Subject: Bug #61033 __FUNCTION__ doesn't report correctly in alias trait methods
From: marc@easen.co.uk (Marc Easen)

--------------070504050908060706030700
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hello everyone,

I've recently came across an odd situation where __FUNCTION__ can 
produce a misleading results when using traits with aliased methods, see 
https://bugs.php.net/bug.php?id=61033. 
<https://bugs.php.net/bug.php?id=61033>
This has been closed and I've been asked start a discussion on here if I 
disagree with the ruling. The reason why I feel this should be changes 
to reflect the actual called function name is that one of main uses of 
the __FUNCTION__ constant it to refer back to the function that is 
currently running, for the use recursive functions:

trait FooTrait {
     public function foo($n) {
         if ($n == 0) return;
         echo $n . PHP_EOL;
         $function = __FUNCTION__;
         $this->$function(--$n);
     }
}

class MyClass {
     use FooTrait { foo as public countdown; }
     public function foo() {
         echo 'MyClass::foo()';
     }
}

$instance = new MyClass();
$instance->countdown(3);

This example will produce running (PHP 5.4 RC7):

     10
     MyClass::foo()

Which as you can see is not the desired effect.

I send this email in the hope this can get the discussion under way 
regarding the magic constant __FUNCTION__.

Thanks,

Marc Easen

--------------070504050908060706030700--