Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:57749 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 67843 invoked from network); 5 Feb 2012 21:58:19 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 Feb 2012 21:58:19 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 207.97.245.143 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 207.97.245.143 smtp143.iad.emailsrvr.com Linux 2.6 Received: from [207.97.245.143] ([207.97.245.143:49157] helo=smtp143.iad.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DD/A0-60839-97BFE2F4 for ; Sun, 05 Feb 2012 16:58:17 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp24.relay.iad1a.emailsrvr.com (SMTP Server) with ESMTP id 7353E1A0157; Sun, 5 Feb 2012 16:58:14 -0500 (EST) X-Virus-Scanned: OK Received: by smtp24.relay.iad1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 0DD581A014D; Sun, 5 Feb 2012 16:58:13 -0500 (EST) Message-ID: <4F2EFB75.6010204@sugarcrm.com> Date: Sun, 05 Feb 2012 13:58:13 -0800 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: "internals@lists.php.net" CC: Sebastian Bergmann References: <4F2EDE20.50207@php.net> In-Reply-To: <4F2EDE20.50207@php.net> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Static Analysis of PHP_5_4 with CLANG From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > http://clang-php54.phpunit.de/ might be of interest to some. > http://bit.ly/u06eCD has details of how to produce this report. Thanks, definitely is a useful thing. Though I'm not sure if this tool is always right. For example, I looked at http://clang-php54.phpunit.de/report-dqJzsw.html#EndPath, and it claims in line 1331 replacement is garbage. However, the only way to get there is to pass through (flags & ENT_HTML_SUBSTITUTE_DISALLOWED_CHARS), and if (flags & ENT_HTML_SUBSTITUTE_DISALLOWED_CHARS) is not 0 then replacement is initialized in lines 1245-1252 by one of the clauses. Looks like this tool does not remember the branches it took before. Am I missing something here or should we submit a bug report to CLANG devs? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227