Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:57664 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 6073 invoked from network); 3 Feb 2012 19:59:16 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Feb 2012 19:59:16 -0000 Authentication-Results: pb1.pair.com header.from=cpriest@zerocue.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=cpriest@zerocue.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zerocue.com designates 74.115.204.80 as permitted sender) X-PHP-List-Original-Sender: cpriest@zerocue.com X-Host-Fingerprint: 74.115.204.80 relay-hub206.domainlocalhost.com Received: from [74.115.204.80] ([74.115.204.80:24336] helo=relay-hub206.domainlocalhost.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 5A/70-26457-19C3C2F4 for ; Fri, 03 Feb 2012 14:59:15 -0500 Received: from MBX202.domain.local ([169.254.19.147]) by HUB206.domain.local ([74.115.204.80]) with mapi id 14.01.0355.002; Fri, 3 Feb 2012 14:59:11 -0500 To: John LeSueur CC: "internals@lists.php.net" Thread-Topic: [PHP-DEV] [PATCH] Property Getters/Setters (v2.4) for review Thread-Index: AcziekMadhrN//SPRYKRy9puoqBsWAAKvSoAAAI5HXA= Date: Fri, 3 Feb 2012 19:59:10 +0000 Message-ID: <9570D903A3BECE4092E924C2985CE48539BCFD40@MBX202.domain.local> References: <9570D903A3BECE4092E924C2985CE48539BCF8A4@MBX202.domain.local> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.64.22] Content-Type: multipart/alternative; boundary="_000_9570D903A3BECE4092E924C2985CE48539BCFD40MBX202domainloc_" MIME-Version: 1.0 Subject: RE: [PHP-DEV] [PATCH] Property Getters/Setters (v2.4) for review From: cpriest@zerocue.com (Clint M Priest) --_000_9570D903A3BECE4092E924C2985CE48539BCFD40MBX202domainloc_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Okay, that's been removed from the patch. :) From: John LeSueur [mailto:john.lesueur@gmail.com] Sent: Friday, February 03, 2012 7:54 AM To: Clint M Priest Cc: internals@lists.php.net Subject: Re: [PHP-DEV] [PATCH] Property Getters/Setters (v2.4) for review Because Zend/zend_language_scanner.c is a generated file, you could exclude= it from your diff, and end up with a much smaller patch. Smaller patches a= re more appealing :) On Fri, Feb 3, 2012 at 6:47 AM, Clint M Priest > wrote: The property accessor functionality is done and is detailed here: https://w= iki.php.net/rfc/propertygetsetsyntax-as-implemented Core Patch: http://www.clintpriest.com/patches/php-core/accessors/2.4.diff The core patch encompasses the entire original RFC and the as-implemented i= ncludes implementation details and edge cases not defined by the original R= FC. Most changes are in zend_compile, zend_object_handlers and zend_language_sc= anner. Thanks, -Clint --_000_9570D903A3BECE4092E924C2985CE48539BCFD40MBX202domainloc_--