Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57663
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain fb.com designates 67.231.145.42 as permitted sender)
To: "internals@lists.php.net" <internals@lists.php.net>
Thread-Topic: stream_socket_server() and timeout
Thread-Index: AQHM4pynCnjX57AQt0K3vDMxXliUpw==
Date: Fri, 3 Feb 2012 17:52:54 +0000
Message-ID: <CB515EF4.30F0B%alok@fb.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.12.0.110505
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D2A738AD9E5BD944A7540FEBFC9AEE6A@fb.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: stream_socket_server() and timeout
From: alok@fb.com (Alok Menghrajani)

Hi,

PHP fails to set the socket_last_error when stream_socket_server() times
out.

It is therefore impossible to tell if a timeout occurred or if the call
failed for some other reason.

Here is a simple piece of that should help understand this issue:

<?php
// Call something that will set socket_last_error()
socket_create(AF_INET, SOCK_STREAM, 666);

$err =3D socket_last_error();
echo 'before: ', socket_strerror($err), "\t", $err, "\n";

// now call stream_socket_accept and timeout
$sock =3D stream_socket_server('tcp://0.0.0.0:0 <http://0.0.0.0:0>');
$client =3D stream_socket_accept($sock, 1);

$err =3D socket_last_error();
echo 'after: ', socket_strerror($err), "\t", $err, "\n";


PHP currently outputs:
before: Protocol not supported	43
after: Protocol not supported	43



I have a patch to fix this issue: http://pastebin.com/6JLjZkNu

The output then becomes:
before: Protocol not supported	43
after: Operation timed out	60

However the patch adds #include "ext/sockets/php_sockets.h" to
ext/standard/streamsfuncs.c. Is that something we are okay living with?


Thanks,
Alok