Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:57659 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 43664 invoked from network); 3 Feb 2012 13:54:16 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Feb 2012 13:54:16 -0000 Authentication-Results: pb1.pair.com header.from=john.lesueur@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=john.lesueur@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.170 as permitted sender) X-PHP-List-Original-Sender: john.lesueur@gmail.com X-Host-Fingerprint: 209.85.216.170 mail-qy0-f170.google.com Received: from [209.85.216.170] ([209.85.216.170:42320] helo=mail-qy0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4A/E2-11798-707EB2F4 for ; Fri, 03 Feb 2012 08:54:15 -0500 Received: by qcmt36 with SMTP id t36so2061367qcm.29 for ; Fri, 03 Feb 2012 05:54:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=w6MJBgw9RXZf2ijjD7+xAdGpyIwdcYUrZ5MHlorsuyM=; b=ZcrrLJMM+3m8WZtM000cknajI18g0PYP2MR4HzaR4l4UDEgEOL/6TbKFL+qnMW20PT 3ZqMSHPjgLaykZpG/yaO9geGt+7Z0aCQw5hYT2BFvlB81e72YxK/Y8qv6LgNq77YpwYk wNwrCAtr+Hp41QzuAcInqj7Xn5OWCDrRdQqN8= MIME-Version: 1.0 Received: by 10.229.136.199 with SMTP id s7mr2742472qct.145.1328277252474; Fri, 03 Feb 2012 05:54:12 -0800 (PST) Received: by 10.224.100.136 with HTTP; Fri, 3 Feb 2012 05:54:12 -0800 (PST) In-Reply-To: <9570D903A3BECE4092E924C2985CE48539BCF8A4@MBX202.domain.local> References: <9570D903A3BECE4092E924C2985CE48539BCF8A4@MBX202.domain.local> Date: Fri, 3 Feb 2012 06:54:12 -0700 Message-ID: To: Clint M Priest Cc: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=0023545303accc089304b80fa54e Subject: Re: [PHP-DEV] [PATCH] Property Getters/Setters (v2.4) for review From: john.lesueur@gmail.com (John LeSueur) --0023545303accc089304b80fa54e Content-Type: text/plain; charset=ISO-8859-1 Because Zend/zend_language_scanner.c is a generated file, you could exclude it from your diff, and end up with a much smaller patch. Smaller patches are more appealing :) On Fri, Feb 3, 2012 at 6:47 AM, Clint M Priest wrote: > The property accessor functionality is done and is detailed here: > https://wiki.php.net/rfc/propertygetsetsyntax-as-implemented > > Core Patch: http://www.clintpriest.com/patches/php-core/accessors/2.4.diff > > The core patch encompasses the entire original RFC and the as-implemented > includes implementation details and edge cases not defined by the original > RFC. > > Most changes are in zend_compile, zend_object_handlers and > zend_language_scanner. > > Thanks, > > -Clint > --0023545303accc089304b80fa54e--