Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57623
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain nopiracy.de from 81.169.146.162 cause and error)
Mime-Version: 1.0 (Apple Message framework v1251.1)
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <alpine.DEB.2.02.1202021628341.20012@whisky.home.derickrethans.nl>
Date: Thu, 2 Feb 2012 17:35:08 +0100
Cc: Pierre Joye <pierre.php@gmail.com>,
 PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <0C9EDEF9-3E36-4C33-B566-6191EDD90568@nopiracy.de>
References: <CALjhHG_wYvJn-Z+x9fJUi+dgmZ+Ha9BD54N5VwhneJM4sg1xBQ@mail.gmail.com> <5FB5CFDA-6FE8-4C20-A9B9-7844ED96659B@nopiracy.de> <CAEZPtU7jtQTDNpUovxxnDdRunjH9BOdX=WbS8JcGz+5Wkz8ocw@mail.gmail.com> <46104CB6-A868-41C3-B8E1-F1E0AC06BCAB@nopiracy.de> <CAEZPtU4oqvSmjU=3Oh3iuRtw5MZLaGTPLWFu-KTtq_ScKsu4Vw@mail.gmail.com> <A53679E3-53ED-423C-AC4C-E9C4A8631C20@nopiracy.de> <alpine.DEB.2.02.1202021628341.20012@whisky.home.derickrethans.nl>
To: Derick Rethans <derick@php.net>
Subject: Re: [PHP-DEV] Suhosin patch disabled by default in Debian php5 builds
From: stefan@nopiracy.de (Stefan Esser)

Hello Derick,

>> * and most probably many more that I do not know from the top of my=20=

>> head (this are already 9 features and Suhosin/HPHP exists since 2004 =
=3D=20
>> 8 years).
>=20
> Lots of stuff in PHP was also "stolen" from Xdebug, but I am not =
whining =20
> about that as the goal is (and has always been) to make PHP better.

I am not whining of something being stolen I trying to demonstrate that =
a lot of the features noone ever saw a need for in PHP have been cloned.
PHP devs repeatedly tell that Suhosin brings no additional value, while =
they clone and clone every time they are hit by a nasty bug.


>> =
http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/main/SAPI.c?r1=3D31=
7225&r2=3D318997
>=20
> I'm sure we'd be more than happy to hear why it's broken and hear =
about=20
> possible suggested fixes.

The purpose of the code is to detect all occurences of \r or \n not =
followed by whitespace and error out.
It is obviously doing something else.

Regards,
Stefan=