Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57542
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <ED.E1.09011.7D9442F4@pb1.pair.com>
References: <ED.E1.09011.7D9442F4@pb1.pair.com>
Date: Sat, 28 Jan 2012 20:43:01 +0000
Message-ID: <CAKxcST_uvLZMUDj9zmUB1xiwZvBuVOsbkeFE3qDYdggNFWzXRA@mail.gmail.com>
To: Justin Martin <frozenfire@php.net>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] PHP_SESSION_* constant values
From: dragoonis@gmail.com (Paul Dragoonis)

On Sat, Jan 28, 2012 at 7:17 PM, Justin Martin <frozenfire@php.net> wrote:
> Hello everyone,
>
> For the result of session_status(), the corresponding constants for the
> sessions state are
>
> =A0- PHP_SESSION_DISABLED =3D 0
> =A0- PHP_SESSION_NONE =3D 1
> =A0- PHP_SESSION_ACTIVE =3D 2
>
> I'd like to suggest we change these values to
>
> =A0- PHP_SESSION_DISABLED =3D -1
> =A0- PHP_SESSION_NONE =3D 0
> =A0- PHP_SESSION_ACTIVE =3D 1
>
> This way, one can do if(session_status()) to check if there is an active
> session, rather than having to compare the result to a constant.
>
> Any objections?

I believe comparing the value against a constant, is always more
readable than wondering what "truthy" means. if(session_status() =3D=3D=3D
PHP_SESSION_ACTIVE) is much self-documenting than the proposed change.

Therefore I object to this change.

- Paul

>
> Thanks,
> Justin Martin
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>