Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57493
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4F1F190F.1090009@oracle.com>
References: <CAMU2iguFaD5dK0E1d4K9uuRaMwkrH7tVqKAeH5BfnV6WcjFi1Q@mail.gmail.com>
	<4F1F190F.1090009@oracle.com>
Date: Tue, 24 Jan 2012 14:02:40 -0700
Message-ID: <CAMU2igt=-6nMf7UyVFsEZMia84mGrn_J9PmJDGbqFwfeBnCSgA@mail.gmail.com>
To: Christopher Jones <christopher.jones@oracle.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Patch inclusions
From: jason.gerfen@gmail.com (Jason Gerfen)

On Tue, Jan 24, 2012 at 1:48 PM, Christopher Jones
<christopher.jones@oracle.com> wrote:
>
>
> On 01/24/2012 03:36 AM, Jason Gerfen wrote:
>>
>> I just have a general question regarding patch inclusions. When a
>> patch is submitted is there a formal review and testing of the patch
>> prior to inclusion? From what I have been following from this list is
>> that the process is patches get applied to new/existing bug/feature
>> requests, bug fixes are priority numero uno, test cases should
>> accompany new functions then testing? How likely are patches which may
>> receive low usage from developers still applied?
>>
>
> What you see on this list and on IRC (#php.pecl on EFNet) is what
> happens. =A0It can take some persistence for people without commit karma
> to get low interest patches applied because it can be hard to find a
> reviewer/committer. =A0Having a clean patch with clear testcases helps.
>

Good to know.

When you say 'clear' test cases, I assume you mean a .phpt file which
calls and evaluates any new function as well as its available options.

>
>> Also, besides the usual retrieving latest testing branch, compiling
>> running tests etc. how else can one help?
>
>
> There are bugs to be triaged, documentation to be updated
> (https://edit.php.net), the website prototype to be completed
> (http://prototype.php.net/), information about PHP development
> processes to be gathered & shared (I'm thinking about git here), new
> community members to be greeted...
>

So my best bet in contributing is to try my hand at patching bugs vs.
implementing feature requests as I did in
https://bugs.php.net/bug.php?id=3D38917

> Chris
>
> --
> Email: christopher.jones@oracle.com
> Tel: =A0+1 650 506 8630
> Blog: =A0http://blogs.oracle.com/opal/



--=20
Jas