Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:57492 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 35974 invoked from network); 24 Jan 2012 20:49:02 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Jan 2012 20:49:02 -0000 Authentication-Results: pb1.pair.com smtp.mail=christopher.jones@oracle.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=christopher.jones@oracle.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain oracle.com from 148.87.113.117 cause and error) X-PHP-List-Original-Sender: christopher.jones@oracle.com X-Host-Fingerprint: 148.87.113.117 rcsinet15.oracle.com Received: from [148.87.113.117] ([148.87.113.117:51031] helo=rcsinet15.oracle.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 04/28-15695-A391F1F4 for ; Tue, 24 Jan 2012 15:48:59 -0500 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id q0OKms4H004014 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 24 Jan 2012 20:48:55 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q0OKmr7f009046 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 24 Jan 2012 20:48:53 GMT Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q0OKmq8s021249; Tue, 24 Jan 2012 14:48:53 -0600 Received: from [130.35.70.154] (/130.35.70.154) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 24 Jan 2012 12:48:52 -0800 Message-ID: <4F1F190F.1090009@oracle.com> Date: Tue, 24 Jan 2012 12:48:15 -0800 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: Jason Gerfen CC: internals@lists.php.net References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090208.4F1F1937.003F,ss=1,re=0.000,fgs=0 Subject: Re: [PHP-DEV] Patch inclusions From: christopher.jones@oracle.com (Christopher Jones) On 01/24/2012 03:36 AM, Jason Gerfen wrote: > I just have a general question regarding patch inclusions. When a > patch is submitted is there a formal review and testing of the patch > prior to inclusion? From what I have been following from this list is > that the process is patches get applied to new/existing bug/feature > requests, bug fixes are priority numero uno, test cases should > accompany new functions then testing? How likely are patches which may > receive low usage from developers still applied? > What you see on this list and on IRC (#php.pecl on EFNet) is what happens. It can take some persistence for people without commit karma to get low interest patches applied because it can be hard to find a reviewer/committer. Having a clean patch with clear testcases helps. > Also, besides the usual retrieving latest testing branch, compiling > running tests etc. how else can one help? There are bugs to be triaged, documentation to be updated (https://edit.php.net), the website prototype to be completed (http://prototype.php.net/), information about PHP development processes to be gathered & shared (I'm thinking about git here), new community members to be greeted... Chris -- Email: christopher.jones@oracle.com Tel: +1 650 506 8630 Blog: http://blogs.oracle.com/opal/