Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:57478 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 84918 invoked from network); 23 Jan 2012 09:02:53 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Jan 2012 09:02:53 -0000 Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.170 as permitted sender) X-PHP-List-Original-Sender: laruence@gmail.com X-Host-Fingerprint: 209.85.220.170 mail-vx0-f170.google.com Received: from [209.85.220.170] ([209.85.220.170:59385] helo=mail-vx0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DA/F2-60416-C322D1F4 for ; Mon, 23 Jan 2012 04:02:53 -0500 Received: by vcbf11 with SMTP id f11so1837125vcb.29 for ; Mon, 23 Jan 2012 01:02:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=DQg2sFBJTEm6aWIOlUnkUwRxlLR9HH1s1khe2gQKs58=; b=HPxuR6ghLko7tsQIzb14aE03CckI5w4Fh/CxOV+eLJWBvn8UQwggG6ZIcGfr0XJfFL FXTJER28hnrtrxiqlwtGxG7ys6Tp7AliDfi/AWW9hSimMwmxxuw0efSjEQKgXz5iiPHs r7YOx5OvWry3HE368kdO77NGPrRSkyaej8H6Q= Received: by 10.220.154.10 with SMTP id m10mr3947638vcw.37.1327309370282; Mon, 23 Jan 2012 01:02:50 -0800 (PST) MIME-Version: 1.0 Sender: laruence@gmail.com Received: by 10.220.7.19 with HTTP; Mon, 23 Jan 2012 01:02:29 -0800 (PST) In-Reply-To: <4F1D15CC.7020001@zend.com> References: <4F1D15CC.7020001@zend.com> Date: Mon, 23 Jan 2012 17:02:29 +0800 X-Google-Sender-Auth: FNkz18Gebl0JGOEGMDMfKrGpkHA Message-ID: To: Dmitry Stogov Cc: Stas Malyshev , dsp@php.net, Rasmus Lerdorf , dsoria@gmx.net, stas@php.net, PHP Internals Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: can I commit fix for Bug #60825? From: laruence@php.net (Laruence) On Mon, Jan 23, 2012 at 4:09 PM, Dmitry Stogov wrote: > Hi Laruence, > > I'm not sure if the proposed patch fixes all the problems. > > Imagine that __FILE__ stored in some PHP variable and accessed after > include() has finished. That time C variable "tmp_inc_filename" won't be > valid but PHP variable may still refer to it. > Hi, I am not sure whether I got your point, but zend_std_cast_object_tostring will duplicate that "string", so zval_dtor tmp_inc_filename will okey(just efree that duplicate) I think. :) thanks > I didn't try to reproduce it, so I might be wrong. > > Thanks. Dmitry. > > > On 01/22/2012 06:42 AM, Laruence wrote: >> >> send again, >> >> dsp said he didn't received. >> >> thanks >> >> On Sun, Jan 22, 2012 at 1:19 AM, Laruence =C2=A0wrote: >>> >>> Hi: >>> >>> =C2=A0I have fixed #60825 (Segfault when running symfony 2 tests) >>> >>> =C2=A0cvs mail here: http://news.php.net/php.cvs/67503 >>> >>> =C2=A0should I also commit this fix to 5.4 branch now? >>> >>> thanks >>> >>> -- >>> Laruence =C2=A0Xinchen Hui >>> http://www.laruence.com/ >> >> >> >> > --=20 Laruence =C2=A0Xinchen Hui http://www.laruence.com/