Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:57475 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 75132 invoked from network); 23 Jan 2012 08:09:59 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Jan 2012 08:09:59 -0000 Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.199.177.89 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 212.199.177.89 il-mr1.zend.com Received: from [212.199.177.89] ([212.199.177.89:57841] helo=il-mr1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 7C/31-60416-2D51D1F4 for ; Mon, 23 Jan 2012 03:09:56 -0500 Received: from il-gw1.zend.com (unknown [10.1.1.22]) by il-mr1.zend.com (Postfix) with ESMTP id 9434C607C7; Mon, 23 Jan 2012 10:08:20 +0200 (IST) Received: from tpl2.home (10.1.10.10) by il-ex2.zend.net (10.1.1.22) with Microsoft SMTP Server id 14.1.255.0; Mon, 23 Jan 2012 10:09:21 +0200 Message-ID: <4F1D15CC.7020001@zend.com> Date: Mon, 23 Jan 2012 12:09:48 +0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 MIME-Version: 1.0 To: Laruence CC: Stas Malyshev , , Rasmus Lerdorf , , , PHP Internals References: In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.1.10.10] Subject: Re: can I commit fix for Bug #60825? From: dmitry@zend.com (Dmitry Stogov) Hi Laruence, I'm not sure if the proposed patch fixes all the problems. Imagine that __FILE__ stored in some PHP variable and accessed after include() has finished. That time C variable "tmp_inc_filename" won't be valid but PHP variable may still refer to it. I didn't try to reproduce it, so I might be wrong. Thanks. Dmitry. On 01/22/2012 06:42 AM, Laruence wrote: > send again, > > dsp said he didn't received. > > thanks > > On Sun, Jan 22, 2012 at 1:19 AM, Laruence wrote: >> Hi: >> >> I have fixed #60825 (Segfault when running symfony 2 tests) >> >> cvs mail here: http://news.php.net/php.cvs/67503 >> >> should I also commit this fix to 5.4 branch now? >> >> thanks >> >> -- >> Laruence Xinchen Hui >> http://www.laruence.com/ > > >