Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:57457 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 78794 invoked from network); 20 Jan 2012 08:49:47 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Jan 2012 08:49:47 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.173 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 67.192.241.173 smtp173.dfw.emailsrvr.com Linux 2.6 Received: from [67.192.241.173] ([67.192.241.173:51090] helo=smtp173.dfw.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id ED/E5-42843-AAA291F4 for ; Fri, 20 Jan 2012 03:49:46 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp17.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id B05D01882F7; Fri, 20 Jan 2012 03:49:43 -0500 (EST) X-Virus-Scanned: OK Received: by smtp17.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 596AE188137; Fri, 20 Jan 2012 03:49:43 -0500 (EST) Message-ID: <4F192AA6.4040602@sugarcrm.com> Date: Fri, 20 Jan 2012 00:49:42 -0800 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: Yasuo Ohgaki CC: PHP Internals References: <4F08C9D9.9050009@sugarcrm.com> <4F18C9A5.9070607@sugarcrm.com> <4F1912CB.9030404@sugarcrm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Code freeze for 5.4 From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > We can make new session ID in PS_OPEN_FUNC() or PS_READ_FUNC() always > when ID is not already initialized one, by calling private validation > function from > PS_OPEN_FUNC() or PS_READ_FUNC(). However, I think it's more cleaner to > keep PS module's modular architecture. > > Current session module's code is complex enough. Not many people would > understand > the logic at a glance. New PS module writers should always write SID validation > function. Separate API is easier for most people, I suppose. I think calling one function wouldn't add that much and can be clearly commented if something is not clear enough from the code. > If it's ok to add structure members that requires current patch, > I'll commit new module structure now. And I'll commit the rest > for 5.4.1. No, please don't commit anything in 5.4. I don't want any large changes now. > If you prefer to maintain current structure/API, I'll modify patch. > I would like to add strict session to PHP 5.3, so I have to do that anyway > for binary compatibility. I'd propose to make a binary-compatible change for 5.3 and 5.4.1, and discuss what we do for trunk - I still like the idea of keeping less handlers better, and if that means we can have the same patch for all branches, then it's an added bonus. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227