Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57402
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.21 cause and error)
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: internals@lists.php.net
References: <CAM4sM9FhzFv70U-X8-iRC52_0c+2=_gbVOjjx9_g8d5Dux-rHQ@mail.gmail.com>
Date: Tue, 17 Jan 2012 22:27:07 +0100
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Organization: =?utf-8?Q?N=C3=BAcleo_de_Eng=2E_Biom=C3=A9di?=
 =?utf-8?Q?ca_do_I=2ES=2ET=2E?=
Message-ID: <op.v78y7hnxidpuyk@damnation>
In-Reply-To: <CAM4sM9FhzFv70U-X8-iRC52_0c+2=_gbVOjjx9_g8d5Dux-rHQ@mail.gmail.com>
User-Agent: Opera Mail/11.60 (Win32)
Subject: Re: [PHP-DEV] Reflection to remove final
From: glopes@nebm.ist.utl.pt ("Gustavo Lopes")

On Mon, 16 Jan 2012 19:06:31 +0100, Jan Dolecek <juzna.cz@gmail.com> wrote:

> Hi,
>
> reflection is a great tool for testing, but it still misses support
> for mocking classes/methods marked as final. I created a small patch
> https://gist.github.com/1621839#file_php_finals.patch, examples how to
> use it https://gist.github.com/1621839#file_final_test.php and wrote a
> short article explaining it:
> http://blog.juzna.cz/2012/01/mock-vs-final-fights-in-testing/.
>

This doesn't seem right.  Correct me if I'm wrong: for internal classes,  
their data structures are allocated permanently, so I'd say the effects of  
removing the flag would be permanent (i.e., would affect subsequent  
requests). And for threaded builds this could cause races between the  
threads.

-- 
Gustavo Lopes