Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57398
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAM4sM9EGo3EdBrjJ89=heAko8AouzbVDEpbfokYjJp=vZ6g+AQ@mail.gmail.com>
References: <CAM4sM9FhzFv70U-X8-iRC52_0c+2=_gbVOjjx9_g8d5Dux-rHQ@mail.gmail.com>
	<CAEZPtU6W2FxQ0XbS4MKJxciYAFtwpv6xNbEG2HVMJ_xBg18Txw@mail.gmail.com>
	<4F155351.7030505@php.net>
	<CAMUwpuRhHB0c7ZV-axiHdyT6aS4gN1+jNmEk0JJ3uhjP9J_jng@mail.gmail.com>
	<CAMUwpuRTqcEk_vR6MT1ryteiTc64vQPfuovyHu6eqdDPN=NCeQ@mail.gmail.com>
	<4F155B73.3060604@php.net>
	<CAM4sM9EGo3EdBrjJ89=heAko8AouzbVDEpbfokYjJp=vZ6g+AQ@mail.gmail.com>
Date: Tue, 17 Jan 2012 14:31:39 +0100
Message-ID: <CAEZPtU588hToxShtzEx4D9LpqCpyZK4g2kp2oMR+97UdwGCfAA@mail.gmail.com>
To: Jan Dolecek <juzna.cz@gmail.com>
Cc: Sebastian Bergmann <sebastian@php.net>, internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Reflection to remove final
From: pierre.php@gmail.com (Pierre Joye)

As it is not that bad for trunk, I think we should wait a bit before
commiting this patch, there are still need for discussions and we
should give some time to other people to comment the feature (the
implementation is trivial as this stage). Sebastian, mind to revert it
until we are done with the discussions?

On Tue, Jan 17, 2012 at 2:15 PM, Jan Dolecek <juzna.cz@gmail.com> wrote:
> Sebastian, thanks for the commit. But actually as I see the tests, I
> may have not specified it enough:
>
> ReflectionClass::setFinal(false) removes the final from the class, not
> it's methods.
>
> This test case
> http://svn.php.net/viewvc/php/php-src/trunk/ext/reflection/tests/Reflecti=
onClass_setFinal.phpt?view=3Dmarkup&pathrev=3D322390
> should have:
>
> final class a { =A0// class is final
> =A0public function b() { // method is not
> =A0 ...
> =A0}
> }
>
> Thanks
>
> Jan Dolecek
> juzna.cz@gmail.com
>
>
>
> On Tue, Jan 17, 2012 at 12:28 PM, Sebastian Bergmann <sebastian@php.net> =
wrote:
>> Am 17.01.2012 12:03, schrieb jpauli:
>>> The patch just adds setFinal() to ReflectionClass.
>>> What about ReflectionMethod?
>>
>> =A0From the patch
>>
>> +/* {{{ proto public void ReflectionMethod::setFinal([bool isFinal =3D t=
rue])
>> + Sets/unsets class as final */
>> +ZEND_METHOD(reflection_method, setFinal)
>>
>> +/* {{{ proto public void ReflectionClass::setFinal([bool isFinal =3D tr=
ue])
>> + Sets/unsets class as final */
>> +ZEND_METHOD(reflection_class, setFinal)
>>
>>
>> =A0TL;DR: All is well :)
>>
>> --
>> Sebastian Bergmann =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0Co-Founder and=
 Principal Consultant
>> http://sebastian-bergmann.de/ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 http://thePHP.cc/
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>



--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org