Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57397
Return-Path: <juzna.cz@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 32717 invoked from network); 17 Jan 2012 13:15:42 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 17 Jan 2012 13:15:42 -0000
Authentication-Results: pb1.pair.com smtp.mail=juzna.cz@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=juzna.cz@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.210.170 as permitted sender)
X-PHP-List-Original-Sender: juzna.cz@gmail.com
X-Host-Fingerprint: 209.85.210.170 mail-iy0-f170.google.com  
Received: from [209.85.210.170] ([209.85.210.170:40168] helo=mail-iy0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id DE/06-02309-D74751F4 for <internals@lists.php.net>; Tue, 17 Jan 2012 08:15:41 -0500
Received: by iaoo28 with SMTP id o28so2454641iao.29
        for <internals@lists.php.net>; Tue, 17 Jan 2012 05:15:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        bh=hEEsqIosejA5/fHaFGBN5Dj0/W174V6tGPG0PkBEewM=;
        b=Icr59mKWYoyPP83yLD7naS2m8Mvfu/wFMH8GENEm5iUXxcmVAaBw8wzNsb+8JSIOlU
         xVpwXO1DFNB8LxdjCTp1WJKP398yZHQBiDzHJFLoIAgqivvVkMc8Vz7cCpD1iUz7rUPe
         0fwoGjVBuB8fev7q+XZ7AfCo2mOijmvroPfk8=
Received: by 10.50.46.196 with SMTP id x4mr17559228igm.15.1326806139190; Tue,
 17 Jan 2012 05:15:39 -0800 (PST)
MIME-Version: 1.0
Received: by 10.231.203.81 with HTTP; Tue, 17 Jan 2012 05:15:18 -0800 (PST)
In-Reply-To: <4F155B73.3060604@php.net>
References: <CAM4sM9FhzFv70U-X8-iRC52_0c+2=_gbVOjjx9_g8d5Dux-rHQ@mail.gmail.com>
 <CAEZPtU6W2FxQ0XbS4MKJxciYAFtwpv6xNbEG2HVMJ_xBg18Txw@mail.gmail.com>
 <4F155351.7030505@php.net> <CAMUwpuRhHB0c7ZV-axiHdyT6aS4gN1+jNmEk0JJ3uhjP9J_jng@mail.gmail.com>
 <CAMUwpuRTqcEk_vR6MT1ryteiTc64vQPfuovyHu6eqdDPN=NCeQ@mail.gmail.com> <4F155B73.3060604@php.net>
Date: Tue, 17 Jan 2012 14:15:18 +0100
Message-ID: <CAM4sM9EGo3EdBrjJ89=heAko8AouzbVDEpbfokYjJp=vZ6g+AQ@mail.gmail.com>
To: Sebastian Bergmann <sebastian@php.net>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Reflection to remove final
From: juzna.cz@gmail.com (Jan Dolecek)

Sebastian, thanks for the commit. But actually as I see the tests, I
may have not specified it enough:

ReflectionClass::setFinal(false) removes the final from the class, not
it's methods.

This test case
http://svn.php.net/viewvc/php/php-src/trunk/ext/reflection/tests/Reflection=
Class_setFinal.phpt?view=3Dmarkup&pathrev=3D322390
should have:

final class a {  // class is final
  public function b() { // method is not
   ...
  }
}

Thanks

Jan Dolecek
juzna.cz@gmail.com



On Tue, Jan 17, 2012 at 12:28 PM, Sebastian Bergmann <sebastian@php.net> wr=
ote:
> Am 17.01.2012 12:03, schrieb jpauli:
>> The patch just adds setFinal() to ReflectionClass.
>> What about ReflectionMethod?
>
> =C2=A0From the patch
>
> +/* {{{ proto public void ReflectionMethod::setFinal([bool isFinal =3D tr=
ue])
> + Sets/unsets class as final */
> +ZEND_METHOD(reflection_method, setFinal)
>
> +/* {{{ proto public void ReflectionClass::setFinal([bool isFinal =3D tru=
e])
> + Sets/unsets class as final */
> +ZEND_METHOD(reflection_class, setFinal)
>
>
> =C2=A0TL;DR: All is well :)
>
> --
> Sebastian Bergmann =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0Co-Founder and Principal Consultant
> http://sebastian-bergmann.de/ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 http://thePHP.cc/
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>