Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:57388 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 13043 invoked from network); 17 Jan 2012 11:04:19 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 Jan 2012 11:04:19 -0000 Authentication-Results: pb1.pair.com header.from=julienpauli@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=julienpauli@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.83.42 as permitted sender) X-PHP-List-Original-Sender: julienpauli@gmail.com X-Host-Fingerprint: 74.125.83.42 mail-ee0-f42.google.com Received: from [74.125.83.42] ([74.125.83.42:36783] helo=mail-ee0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B5/32-02309-1B5551F4 for ; Tue, 17 Jan 2012 06:04:18 -0500 Received: by eekd49 with SMTP id d49so1363119eek.29 for ; Tue, 17 Jan 2012 03:04:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=GKfzq/56uE+H+ghy4O3DtJ/tn0Z9vqosO4u+RUpmUA8=; b=koFKXB1AyzfpJkvCwTbSaP7eorZm85JW/su+9coYL/sRJtJiBviEkfXdgzpn3I1UQO AktFYTygCSHQcfh25D/OsI72mILclJlIDl0yQfAreKhS4gWajFLi3ArCiGbdB8mJAAGU +BmlPglydvKjVFimYW+QmFW9/bmaFzgmuq9qA= Received: by 10.213.113.14 with SMTP id y14mr4094525ebp.0.1326798254573; Tue, 17 Jan 2012 03:04:14 -0800 (PST) MIME-Version: 1.0 Sender: julienpauli@gmail.com Received: by 10.213.30.17 with HTTP; Tue, 17 Jan 2012 03:03:33 -0800 (PST) In-Reply-To: References: <4F155351.7030505@php.net> Date: Tue, 17 Jan 2012 12:03:33 +0100 X-Google-Sender-Auth: HJmV8Q4B2Frk7f9jYYYymhPZhP0 Message-ID: To: Sebastian Bergmann Cc: internals@lists.php.net Content-Type: multipart/alternative; boundary=0015174c0ef0a70a6a04b6b74a95 Subject: Re: [PHP-DEV] Reflection to remove final From: jpauli@php.net (jpauli) --0015174c0ef0a70a6a04b6b74a95 Content-Type: text/plain; charset=ISO-8859-1 Just one last word : The patch just adds setFinal() to ReflectionClass. What about ReflectionMethod ? Not very usefull for the mocking purpose, but that would be good for the Reflection API. Julien On Tue, Jan 17, 2012 at 12:00 PM, jpauli wrote: > +1, I like the idea as well. > How didn't we think about that earlier... ? > > Julien > > > On Tue, Jan 17, 2012 at 11:54 AM, Sebastian Bergmann wrote: > >> Am 17.01.2012 11:34, schrieb Pierre Joye: >> > Patch looks good, but coding standard. >> >> If there are no objections, I can fix the CS issue and commit the patch >> to trunk. >> >> -- >> Sebastian Bergmann Co-Founder and Principal Consultant >> http://sebastian-bergmann.de/ http://thePHP.cc/ >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > --0015174c0ef0a70a6a04b6b74a95--