Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:57385 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 4857 invoked from network); 17 Jan 2012 10:34:19 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 Jan 2012 10:34:19 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.42 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.213.42 mail-yw0-f42.google.com Received: from [209.85.213.42] ([209.85.213.42:47557] helo=mail-yw0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 28/70-02309-AAE451F4 for ; Tue, 17 Jan 2012 05:34:19 -0500 Received: by yhgg71 with SMTP id g71so1736750yhg.29 for ; Tue, 17 Jan 2012 02:34:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=oD/iyb3hm2c/ju7TIVbdoUFPlIwqz7020g5cWzSEC3E=; b=Rp5DqqCDjfKYPrYh59CSMSwGhg+fIxBl2MDSBtC9jcvAO/Cqq+K+9tpP1YVLmyp0UL YVa56/PmhZN9hB8utncYskJLoj4J4EHO1rpGzmj0IOKzzb9xc1fz/NZjqZ0xwFCkVS90 fx6IjNA5OHueZu83Cw8CXJSmrB+xEqg+twDcI= MIME-Version: 1.0 Received: by 10.236.175.231 with SMTP id z67mr22871477yhl.23.1326796456301; Tue, 17 Jan 2012 02:34:16 -0800 (PST) Received: by 10.147.169.10 with HTTP; Tue, 17 Jan 2012 02:34:16 -0800 (PST) In-Reply-To: References: Date: Tue, 17 Jan 2012 11:34:16 +0100 Message-ID: To: Jan Dolecek Cc: PHP Internals Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [PHP-DEV] Reflection to remove final From: pierre.php@gmail.com (Pierre Joye) hi Jan! Patch looks good, but coding standard. Please always use brackets, even for one line condition (if () foo else bar). Cheers, On Mon, Jan 16, 2012 at 7:06 PM, Jan Dolecek wrote: > Hi, > > reflection is a great tool for testing, but it still misses support > for mocking classes/methods marked as final. I created a small patch > https://gist.github.com/1621839#file_php_finals.patch, examples how to > use it https://gist.github.com/1621839#file_final_test.php and wrote a > short article explaining it: > http://blog.juzna.cz/2012/01/mock-vs-final-fights-in-testing/. > > Can you include it into svn pls? > Thanks > > Jan Dolecek > juzna.cz@gmail.com > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org