Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:57384 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 2956 invoked from network); 17 Jan 2012 10:22:18 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 Jan 2012 10:22:18 -0000 Authentication-Results: pb1.pair.com smtp.mail=sebastian@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=sebastian@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 93.190.64.37 as permitted sender) X-PHP-List-Original-Sender: sebastian@php.net X-Host-Fingerprint: 93.190.64.37 mail-7.de-punkt.de Received: from [93.190.64.37] ([93.190.64.37:48279] helo=mail-7.de-punkt.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 38/10-02309-7DB451F4 for ; Tue, 17 Jan 2012 05:22:16 -0500 Received: (qmail 4075 invoked by uid 511); 17 Jan 2012 10:22:16 -0000 Received: by simscan 1.3.1 ppid: 4066, pid: 4073, t: 0.3250s scanners: attach: 1.4.0 Received: from unknown (HELO ?192.168.2.31?) (sb@sebastian-bergmann.de@93.214.177.168) by 0 with ESMTPA; 17 Jan 2012 10:22:15 -0000 Message-ID: <4F154BCE.4090000@php.net> Date: Tue, 17 Jan 2012 11:22:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: internals@lists.php.net References: In-Reply-To: X-Enigmail-Version: 1.3.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Reflection to remove final From: sebastian@php.net (Sebastian Bergmann) Am 16.01.2012 19:06, schrieb Jan Dolecek: > reflection is a great tool for testing, but it still misses support > for mocking classes/methods marked as final. I created a small patch > https://gist.github.com/1621839#file_php_finals.patch, examples how to > use it https://gist.github.com/1621839#file_final_test.php and wrote a > short article explaining it: > http://blog.juzna.cz/2012/01/mock-vs-final-fights-in-testing/. +1 from me for the idea. Implementation looks good at first glance as well, but I let more knowledgable C developers be the judge of that. -- Sebastian Bergmann Co-Founder and Principal Consultant http://sebastian-bergmann.de/ http://thePHP.cc/