Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57251
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.54 as permitted sender)
MIME-Version: 1.0
Sender: patrick.allaert@gmail.com
In-Reply-To: <CAGMw7vFSLkuXJsMF4fs3+0yQnMz5Dbxw44rFLn1b_h0GMJ0UtQ@mail.gmail.com>
References: <CAGMw7vE9t8TimNN8bYXU2zG2fHCoR2P+LN8ZcurREDKPomK1Xg@mail.gmail.com>
	<CAEZPtU5xnhnVdk8Yw0hmxLkdK25TTygFD9Umk5A_ApZgOGVbBg@mail.gmail.com>
	<CAEZPtU5smafux16aOq+vpsght5KY_+JacF8mEqusGzYTuptZZA@mail.gmail.com>
	<alpine.DEB.2.02.1112241154350.27751@whisky.home.derickrethans.nl>
	<CAGMw7vEpvpNju96c7OthFa3-r87X6tPO5goYMR3YWKuTkPvSDw@mail.gmail.com>
	<CAEZPtU6nYTyCN2snxcmOzJ=jULN=HWVROghS2aK6yUj0X3LJ4g@mail.gmail.com>
	<CALkpNnQ4L2n=ju==eaVUT0_PB_cChjLdLH=KX5LHRgqo-vTXtA@mail.gmail.com>
	<CAEZPtU58zfhk+-DAaUCWmux=bCxF-+DPHwkBbVV8HRr7EQeXYg@mail.gmail.com>
	<CACwt+JeqyAoQ-e_hwAAwxZizxSnCEEj_W=6H5nyYVtH4xmmDNQ@mail.gmail.com>
	<alpine.DEB.2.02.1112271036150.27751@whisky.home.derickrethans.nl>
	<CAEZPtU78SaC1zSrcNhVpseig4Mo1pDvX8BFXViyB-YW+rTe6LA@mail.gmail.com>
	<alpine.DEB.2.02.1112271219040.27751@whisky.home.derickrethans.nl>
	<CAEZPtU7ijYLeHQM+iQqFdT2rnk1Oxf=PJdCWci8TZcHFf4px_w@mail.gmail.com>
	<alpine.DEB.2.02.1112271251120.27751@whisky.home.derickrethans.nl>
	<CALkpNnQ8Ys4Hx_Xfs=Y6FR5W9mNzHnBq0mn4FWDeOEw32_4QRw@mail.gmail.com>
	<CACwt+Jd+eMWKWkAU8e_w+fr5LwPQ2ijN-KVg5K=_sKK7WV-Wbw@mail.gmail.com>
	<CALkpNnQWe0MDZiME4HA1nRRfJxdxOV2HFqBkCFB2=0zQKNnWRw@mail.gmail.com>
	<CACwt+JekYOsosZAPzcrRg2jZf3fgd_L6n3U88W38Hajr0YbW5A@mail.gmail.com>
	<CAH-PCH6k1Pv-sMYusWTM5t0nv1VDdtJcZWqBinNmc1Op2ZRwsw@mail.gmail.com>
	<CAGMw7vFSLkuXJsMF4fs3+0yQnMz5Dbxw44rFLn1b_h0GMJ0UtQ@mail.gmail.com>
Date: Fri, 6 Jan 2012 14:41:16 +0100
Message-ID: <CACwt+JeT0Bo0fTfhqNKHzZ0Rau-zFqXEAk8onyNgUMTKqNq3UQ@mail.gmail.com>
To: =?UTF-8?B?QW5kcsOpIFLDuG1ja2U=?= <ar@ez.no>
Cc: Ferenc Kovacs <tyra3l@gmail.com>, Ilia Alshanetsky <ilia@ilia.ws>, 
	PHP Developers Mailing List <internals@lists.php.net>, Pierre Joye <pierre.php@gmail.com>, 
	David Soria Parra <dsp@php.net>, Stas Malyshev <smalyshev@sugarcrm.com>, Derick Rethans <derick@php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] REQUEST_TIME change in PHP 5.4
From: patrickallaert@php.net (Patrick ALLAERT)

2012/1/6 Andr=C3=A9 R=C3=B8mcke <ar@ez.no>
>
> On Tue, Dec 27, 2011 at 9:01 PM, Ferenc Kovacs <tyra3l@gmail.com> wrote:
>>
>>
>>
>> On Tue, Dec 27, 2011 at 6:24 PM, Patrick ALLAERT <patrickallaert@php.net=
> wrote:
>>>
>>> 2011/12/27 Ilia Alshanetsky <ilia@ilia.ws>:
>>> > The change is inside 5.4 version which adjust breaks BC.
>>>
>>> I don't follow you here Ilia.
>>>
>>> As per https://wiki.php.net/rfc/releaseprocess:
>>> * "Backward compatibility must be respected with the same major
>>> releases, for example from 5.2 to 5.6."
>>> * Going from x.y.z to x.y+1.z, it is ok to break *binary*
>>> compatibility but "Backward compatibility must be kept".
>>>
>>> However:
>>>
>>> new DateTime("@{$_SERVER['REQUEST_TIME']}");
>>>
>>> works in 5.3 but not in 5.4.
>>> AFAIK, creating a DateTime object based on the REQUEST_TIME is not an
>>> exotic thing.
>>> For sure, the fix is easy, but that is not the point, it *will*
>>> actually break applications.
>>>
>>> Did I miss something?
>>
>>
>> I think that he is referring to that we already break BC with 5.4 (remov=
ing magic_quotes, register_globals,=C2=A0break/continue $var,=C2=A0allow_ca=
ll_time_pass_reference,=C2=A0some deprecated session_ functions, safe_mode,=
 etc. for a complete list see=C2=A0http://svn.php.net/viewvc/php/php-src/br=
anches/PHP_5_4/UPGRADING?view=3Dmarkup=C2=A0)
>
>
>
> These are=C2=A0mostly=C2=A0removal of features, and most of these have be=
en deprecated for quite a while.
> The REQUEST_TIME change however is a change of=C2=A0behaviour=C2=A0that h=
as not been warned about up front, which imo is a worse BC break then most =
of the rest. And arguing for ignoring one bc break/bug/mistake because ther=
e are others is.. well.. :)
>
>
>>
>>
>> However I tend to agree with you, that this BC break isn't really worth =
it, we can see that there are common apps stumbling across this change, and=
 albeit the new behavior can be useful for many people, they wouldn't reall=
y mind if we add this as a new variable imo.
>
>
>
> Great, so I do think most people agree that this can, and should be fixed=
 before 5.4 by instead expose microtime on a=C2=A0separate=C2=A0variable ca=
lled=C2=A0REQUEST_TIME_FLOAT.
>
> +1

Fixed in master and PHP_5_4 as per discussed/suggested by introducing
$_SERVER['REQUEST_TIME_FLOAT'].

--
Patrick