Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:57249 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 1593 invoked from network); 6 Jan 2012 12:08:22 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Jan 2012 12:08:22 -0000 Authentication-Results: pb1.pair.com smtp.mail=ar@ez.no; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=ar@ez.no; sender-id=unknown Received-SPF: error (pb1.pair.com: domain ez.no from 209.85.210.42 cause and error) X-PHP-List-Original-Sender: ar@ez.no X-Host-Fingerprint: 209.85.210.42 mail-pz0-f42.google.com Received: from [209.85.210.42] ([209.85.210.42:49220] helo=mail-pz0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 84/32-21551-434E60F4 for ; Fri, 06 Jan 2012 07:08:21 -0500 Received: by dadp13 with SMTP id p13so1123433dad.29 for ; Fri, 06 Jan 2012 04:08:18 -0800 (PST) Received: by 10.68.116.199 with SMTP id jy7mr7948426pbb.18.1325851698071; Fri, 06 Jan 2012 04:08:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.2.233 with HTTP; Fri, 6 Jan 2012 04:07:57 -0800 (PST) In-Reply-To: References: Date: Fri, 6 Jan 2012 13:07:57 +0100 Message-ID: To: Ferenc Kovacs Cc: Patrick ALLAERT , Ilia Alshanetsky , PHP Developers Mailing List , Pierre Joye , David Soria Parra , Stas Malyshev , Derick Rethans Content-Type: multipart/alternative; boundary=e89a8ff24c097d0a6f04b5dae737 Subject: Re: [PHP-DEV] REQUEST_TIME change in PHP 5.4 From: ar@ez.no (=?UTF-8?B?QW5kcsOpIFLDuG1ja2U=?=) --e89a8ff24c097d0a6f04b5dae737 Content-Type: text/plain; charset=UTF-8 On Tue, Dec 27, 2011 at 9:01 PM, Ferenc Kovacs wrote: > > > On Tue, Dec 27, 2011 at 6:24 PM, Patrick ALLAERT wrote: > >> 2011/12/27 Ilia Alshanetsky : >> > The change is inside 5.4 version which adjust breaks BC. >> >> I don't follow you here Ilia. >> >> As per https://wiki.php.net/rfc/releaseprocess: >> * "Backward compatibility must be respected with the same major >> releases, for example from 5.2 to 5.6." >> * Going from x.y.z to x.y+1.z, it is ok to break *binary* >> compatibility but "Backward compatibility must be kept". >> >> However: >> >> new DateTime("@{$_SERVER['REQUEST_TIME']}"); >> >> works in 5.3 but not in 5.4. >> AFAIK, creating a DateTime object based on the REQUEST_TIME is not an >> exotic thing. >> For sure, the fix is easy, but that is not the point, it *will* >> actually break applications. >> >> Did I miss something? > > > I think that he is referring to that we already break BC with 5.4 > (removing magic_quotes, register_globals, break/continue > $var, allow_call_time_pass_reference, some deprecated session_ functions, > safe_mode, etc. for a complete list see > http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/UPGRADING?view=markup > ) > These are mostly removal of features, and most of these have been deprecated for quite a while. The REQUEST_TIME change however is a change of behaviour that has not been warned about up front, which imo is a worse BC break then most of the rest. And arguing for ignoring one bc break/bug/mistake because there are others is.. well.. :) > > However I tend to agree with you, that this BC break isn't really worth > it, we can see that there are common apps stumbling across this change, and > albeit the new behavior can be useful for many people, they wouldn't really > mind if we add this as a new variable imo. > Great, so I do think most people agree that this can, and should be fixed before 5.4 by instead expose microtime on a separate variable called REQUEST_TIME_FLOAT. +1 --e89a8ff24c097d0a6f04b5dae737--