Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:57176 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 43741 invoked from network); 4 Jan 2012 07:13:48 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Jan 2012 07:13:48 -0000 Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.42 as permitted sender) X-PHP-List-Original-Sender: laruence@gmail.com X-Host-Fingerprint: 209.85.212.42 mail-vw0-f42.google.com Received: from [209.85.212.42] ([209.85.212.42:36505] helo=mail-vw0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1D/43-16104-B2CF30F4 for ; Wed, 04 Jan 2012 02:13:48 -0500 Received: by vbbfd1 with SMTP id fd1so13908157vbb.29 for ; Tue, 03 Jan 2012 23:13:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=GgQsQwlevNQbK7cfYvB7pAQZsbKsk/fGYeA/y/Ar44I=; b=SnAQ8UulC5gNa5jAbfOKEJodpxRp57049I0x71FbMfWpLFWV7GCoEAHZqxRaJAYV04 k5I3bx6WyIYowhJibXUHRv3IMjBMq0XUUZqlH2yKlciq4DJADmLNBvzbhO0ImV3QzytB xRTDtm1CXjzmlOWnJhazAruujDMk6xmJLanu4= Received: by 10.52.20.35 with SMTP id k3mr28990308vde.34.1325661225236; Tue, 03 Jan 2012 23:13:45 -0800 (PST) MIME-Version: 1.0 Sender: laruence@gmail.com Received: by 10.220.3.14 with HTTP; Tue, 3 Jan 2012 23:13:24 -0800 (PST) In-Reply-To: <4F03FAE7.8060808@sugarcrm.com> References: <4F03FAE7.8060808@sugarcrm.com> Date: Wed, 4 Jan 2012 15:13:24 +0800 X-Google-Sender-Auth: 5dB9rAd0bTT8JzTJH3FpbKdQ3c8 Message-ID: To: Stas Malyshev Cc: PHP Internals Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] another fix for max_input_vars. From: laruence@php.net (Laruence) Hi: sorry, I didn't put that clearly, I mean, in trigger E_ERROR in php_register_variable will cause php-cgi process exit. and dmitry has fixed that by change the E_ERROR to E_WARNING, my patch is doing the same thing but in another way thanks On Wed, Jan 4, 2012 at 3:08 PM, Stas Malyshev wrot= e: > Hi! > > >> =C2=A0 =C2=A0 it seems you have fix the issue that error in register_var= iable >> will cause php process exit. >> >> =C2=A0 =C2=A0 here is a fix I made before: http://pastebin.com/7BLAVaWr = , =C2=A0I >> think maybe this is a lighter fix. >> >> =C2=A0 =C2=A0 could you review this? =C2=A0 if you think this is okey, = =C2=A0I will commit it. > > > Could you please explain what exactly causes process exit and how it can = be > reproduced? I.e., what is the problem in the patch that is committed now? > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > (408)454-6900 ext. 227 --=20 Laruence =C2=A0Xinchen Hui http://www.laruence.com/