Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:57161 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 53515 invoked from network); 31 Dec 2011 10:56:51 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 31 Dec 2011 10:56:51 -0000 Authentication-Results: pb1.pair.com header.from=mapopa@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=mapopa@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.170 as permitted sender) X-PHP-List-Original-Sender: mapopa@gmail.com X-Host-Fingerprint: 209.85.216.170 mail-qy0-f170.google.com Received: from [209.85.216.170] ([209.85.216.170:48650] helo=mail-qy0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D0/51-44337-27AEEFE4 for ; Sat, 31 Dec 2011 05:56:50 -0500 Received: by qcsd16 with SMTP id d16so9111139qcs.29 for ; Sat, 31 Dec 2011 02:56:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; bh=ubJu0ft+MofkXSCMZR5VFvKT4FqWwu0rHefMPafJRdY=; b=qZOapRBT62/2mGiDBvMwZ/CQr2BuXs8bPocfRNjEqyD0M0gnIfObCAHsknJ5Pp12Ah 60w5OiG4M8cNpk2hvkgGDGLeEHKWhct/7n7bgammLKRr24uC2Chy1h5abyR8hNYjAYFD /HYQ87Pk1NTz0WtBh9L/sYNxEZm2lQPV7LP/c= MIME-Version: 1.0 Received: by 10.229.78.101 with SMTP id j37mr15389945qck.95.1325329007366; Sat, 31 Dec 2011 02:56:47 -0800 (PST) Received: by 10.229.220.203 with HTTP; Sat, 31 Dec 2011 02:56:47 -0800 (PST) Date: Sat, 31 Dec 2011 12:56:47 +0200 Message-ID: To: PHP Developers Mailing List Content-Type: text/plain; charset=ISO-8859-1 Subject: commit rights for ext/pdo folder From: mapopa@gmail.com (marius adrian popa) There are some tests that needs to be skiped for firebird driver I have made the changes in test but i can't commit them added firebird driver case for the test bug 43139 --This line, and those below, will be ignored-- M php-src/trunk/ext/pdo/tests/bug_43139.phpt M php-src/branches/PHP_5_3/ext/pdo/tests/bug_43139.phpt M php-src/branches/PHP_5_4/ext/pdo/tests/bug_43139.phpt svn diff Index: php-src/trunk/ext/pdo/tests/bug_43139.phpt =================================================================== --- php-src/trunk/ext/pdo/tests/bug_43139.phpt (revision 321556) +++ php-src/trunk/ext/pdo/tests/bug_43139.phpt (working copy) @@ -20,6 +20,8 @@ $from = ''; if ($db->getAttribute(PDO::ATTR_DRIVER_NAME) == 'oci') { $from = 'from dual'; +} else if ($db->getAttribute(PDO::ATTR_DRIVER_NAME) == 'firebird') { + $from = 'FROM RDB$DATABASE'; } the related bug with some of the proposed changes (i take one by one and check if it makes sense to skip some of the patches) http://bugs.php.net/55663