Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57097
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender)
References: <4EF7C0EC.8070807@sugarcrm.com>
User-Agent: K-9 Mail for Android
In-Reply-To: <4EF7C0EC.8070807@sugarcrm.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 8bit
Date: Mon, 26 Dec 2011 08:40:11 +0000
To: Stas Malyshev <smalyshev@sugarcrm.com>,PHP Internals <internals@lists.php.net>
Message-ID: <254a46ca-7671-4e38-8fbf-a70dffce2196@email.android.com>
Subject: Re: [PHP-DEV] bug 52062
From: derick@php.net (Derick Rethans)

Stas Malyshev <smalyshev@sugarcrm.com> wrote:

> Hi!
> 
> I see that test for bug 52062 (marked as fixed by this commit: 
> http://svn.php.net/viewvc/?view=revision&amp;revision=320481) now
> fails 
> on my 32-bit system. Looking at the patch and the test, it can not 
> actually succeed, as the test expects this:
> int(100000000000)
> which is not possible on 32-bit system, and the code actually compares
> 
> the result to LONG_MAX which is 32-bit and returns false when it's 
> bigger that that. So I'd like to know what was the intent there:
> 
> 1. Return false on 32-bit and the test should be fixed to account for 
> 32-bit and 64-bit?
> 2. Return float on 32-bit?
> 3. Do something else?
> 
> Please advise.
> -- 
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
> 
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php

I'll have a look when I get back home. Is there anything else you want me to look at?

cheers,
Derick