Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:57091 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 82023 invoked from network); 24 Dec 2011 17:22:29 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Dec 2011 17:22:29 -0000 Authentication-Results: pb1.pair.com header.from=ircmaxell@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ircmaxell@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.42 as permitted sender) X-PHP-List-Original-Sender: ircmaxell@gmail.com X-Host-Fingerprint: 209.85.216.42 mail-qw0-f42.google.com Received: from [209.85.216.42] ([209.85.216.42:55799] helo=mail-qw0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 54/EE-16446-45A06FE4 for ; Sat, 24 Dec 2011 12:22:29 -0500 Received: by qabj40 with SMTP id j40so5878636qab.8 for ; Sat, 24 Dec 2011 09:22:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type; bh=HqXj2TRV6xTnOk9GzigVkFGEAJen0AmZggqDf1pfXqs=; b=p7iMtOo5MdHy8HyGn/4pap5Z2dn0S3FAPOotFNiJBX3+au3XmPFiTaMvWlysRgBfQT s3sKjEQOwAi7a9WlwYz1AnhnXaAWw96jULJ1wUtesHAyFU2Gp7UNF5pZ2yOEZMxSWBfU ztZXo+AZOv8CmcrwaW5W5ikKvr/9CBZqSx+Fo= MIME-Version: 1.0 Received: by 10.224.95.197 with SMTP id e5mr23457988qan.0.1324747345843; Sat, 24 Dec 2011 09:22:25 -0800 (PST) Sender: ircmaxell@gmail.com Received: by 10.229.84.9 with HTTP; Sat, 24 Dec 2011 09:22:25 -0800 (PST) Date: Sat, 24 Dec 2011 12:22:25 -0500 X-Google-Sender-Auth: ITaY-z0xqLaqwQ7VUcNXGH-hx8A Message-ID: To: internals@lists.php.net Content-Type: text/plain; charset=ISO-8859-1 Subject: Bug 60596 - With Patch From: ircmaxell@php.net (Anthony Ferrara) Hey all, I found a superfluous if statement while investigating another issue. I submitted a bug to clean it up and attached a patch: https://bugs.php.net/bug.php?id=60596 It's on line 56 of /ext/spl/spl_engine.c : http://lxr.php.net/xref/PHP_TRUNK/ext/spl/spl_engine.c#56 It's really simple, and would likely be optimized away by the compiler anyway, but I figured it was worth cleaning up... Thanks, Anthony